Fix parsing of ClosureCreation kernel nodes in VM.

runtime/vm/kernel_binary_flowgraph.cc

Index: runtime/vm/kernel_binary_flowgraph.cc
diff --git a/runtime/vm/kernel_binary_flowgraph.cc b/runtime/vm/kernel_binary_flowgraph.cc
index 34a20248b9bb9d8047dbf2d32c18c374395226b6..2ce609a343f08ef5574016dfe0b00dcb295330cb 100644
--- a/runtime/vm/kernel_binary_flowgraph.cc
+++ b/runtime/vm/kernel_binary_flowgraph.cc
@@ -696,7 +696,8 @@ void StreamingScopeBuilder::VisitExpression() {
     case kClosureCreation:
       builder_->SkipCanonicalNameReference();  // read function reference.
       VisitExpression();                       // read context vector.
-      VisitDartType();  // read function type of the closure.
+      VisitDartType();                  // read function type of the closure.
+      builder_->SkipListOfDartTypes();  // read type arguments

[Dmitry Stefantsov, 2017/07/31 15:15:06]

As I mentioned, we maintain these comments related to reading the code from the
.dill file.  The purpose is to make the readings more visible, but also to point
to the parts of AST nodes that are being read.  The informal format is (as I
understood it from the chats with @jensj) is this:

// read|skip <name of the field turned in to words with spaces between them>.

So, the full-stop at the end is missing :)

[sjindel, 2017/07/31 15:44:30]

Done.

       return;
     default:
       UNREACHABLE();
@@ -4009,6 +4010,7 @@ void StreamingFlowGraphBuilder::SkipExpression() {
       SkipCanonicalNameReference();  // read top-level function reference.
       SkipExpression();              // read context vector.
       SkipDartType();                // read function type.
+      SkipListOfDartTypes();         // read type arguments

[Dmitry Stefantsov, 2017/07/31 15:15:06]

Please, add a full-stop at the end.

[sjindel, 2017/07/31 15:44:30]

Done.

       return;
     case kBigIntLiteral:
       SkipStringReference();  // read string reference.
@@ -5904,6 +5906,7 @@ Fragment StreamingFlowGraphBuilder::BuildClosureCreation(
   instructions += Drop();
 
   SkipDartType();  // skip function type of the closure.
+  SkipListOfDartTypes();  // skip list of type arguments (for now)

[Dmitry Stefantsov, 2017/07/31 15:15:06]

Please, remove "(for now)" and add a full-stop.

[sjindel, 2017/07/31 15:44:30]

Done.

 
   return instructions;
 }