Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: pkg/dev_compiler/test/multitest.dart

Issue 2987093002: Use status files for DDC's presubmit script/travis bot (Closed)
Patch Set: feedback, removed unused compile_error_test, skip Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/test/compile_error_tests.dart ('k') | tests/corelib_strong/corelib_strong.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/test/multitest.dart
diff --git a/pkg/dev_compiler/test/multitest.dart b/pkg/dev_compiler/test/multitest.dart
index 95b856e0b56eb5b5d490811554d8dddc63a8ede2..18a439134bf16512e91ed35ca7e62bf6bd98ec6c 100644
--- a/pkg/dev_compiler/test/multitest.dart
+++ b/pkg/dev_compiler/test/multitest.dart
@@ -78,8 +78,8 @@ bool isMultiTest(String contents) => _multiTestRegExp.hasMatch(contents);
// ddd //# 07: static type warning, dynamic type error
// fff
-void extractTestsFromMultitest(String filePath, String contents,
- Map<String, String> tests, Map<String, Set<String>> outcomes) {
+void extractTestsFromMultitest(
+ String filePath, String contents, Map<String, String> tests) {
int first_newline = contents.indexOf('\n');
final String line_separator =
(first_newline == 0 || contents[first_newline - 1] != '\r')
@@ -91,7 +91,8 @@ void extractTestsFromMultitest(String filePath, String contents,
// Create the set of multitests, which will have a new test added each
// time we see a multitest line with a new key.
- Map<String, List<String>> testsAsLines = new Map<String, List<String>>();
+ var testsAsLines = new Map<String, List<String>>();
+ var outcomes = new Map<String, Set<String>>();
// Add the default case with key "none".
testsAsLines['none'] = new List<String>();
« no previous file with comments | « pkg/dev_compiler/test/compile_error_tests.dart ('k') | tests/corelib_strong/corelib_strong.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698