Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: Source/bindings/bindings.gni

Issue 298703005: First pass on blink compiling for GN build (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/BUILD.gn ('k') | Source/build/gn_list_to_space_separated_string.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/bindings.gni
diff --git a/Source/bindings/bindings.gni b/Source/bindings/bindings.gni
index caf79550ef68bde06691d3ecab5b7f4cba45b413..3fd8f42bfe5a5acab168dcd455c7dd12d1bc182c 100644
--- a/Source/bindings/bindings.gni
+++ b/Source/bindings/bindings.gni
@@ -5,13 +5,70 @@
# TODO(brettw) enable this to read the bindings sources (needs some work on the
# .gypi reading script).
#
-#_gypi = exec_script(
-# "//build/gypi_to_gn.py",
-# [ rebase_path("bindings.gypi") ],
-# "scope",
-# [ "bindings.gypi" ])
-#
-#bindings_v8_dir = "//" + rebase_path(_gypi.bindings_v8_dir, "//")
+_gypi = exec_script(
+ "//build/gypi_to_gn.py",
+ [ rebase_path("v8/v8.gypi"),
+ "--replace=<(SHARED_INTERMEDIATE_DIR)=$root_gen_dir" ],
+ "scope",
+ [ "v8/v8.gypi" ])
-# For now, hardcode the only value we need.
bindings_v8_dir = "//third_party/WebKit/Source/bindings/v8"
+blink_output_dir = "$root_gen_dir/blink"
+bindings_output_dir = "$blink_output_dir/bindings"
+
+# Note: these are relative to the bindings/v8 directory.
+bindings_v8_files = _gypi.bindings_v8_files
+bindings_v8_unittest_files = _gypi.bindings_v8_unittest_files
+
+if (is_win && is_official_build) {
+ # On Windows Official release builds, we try to preserve symbol space.
+ bindings_core_generated_aggregate_files = [
+ "$bindings_output_dir/V8GeneratedCoreBindings.cpp",
+ ]
+ bindings_modules_generated_aggregate_files = [
+ "$bindings_output_dir/V8GeneratedModulesBindings.cpp",
+ ]
+} else {
+ bindings_core_generated_aggregate_files = [
+ "$bindings_output_dir/V8GeneratedCoreBindings01.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings02.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings03.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings04.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings05.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings06.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings07.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings08.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings09.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings10.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings11.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings12.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings13.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings14.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings15.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings16.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings17.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings18.cpp",
+ "$bindings_output_dir/V8GeneratedCoreBindings19.cpp",
+ ]
+ bindings_modules_generated_aggregate_files = [
+ "$bindings_output_dir/V8GeneratedModulesBindings01.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings02.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings03.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings04.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings05.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings06.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings07.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings08.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings09.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings10.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings11.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings12.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings13.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings14.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings15.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings16.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings17.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings18.cpp",
+ "$bindings_output_dir/V8GeneratedModulesBindings19.cpp",
+ ]
+}
« no previous file with comments | « Source/bindings/BUILD.gn ('k') | Source/build/gn_list_to_space_separated_string.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698