Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/gypv8sh.py

Issue 298703004: Pass the location of the icu datafile to d8 if its available (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gypv8sh.py
diff --git a/tools/gypv8sh.py b/tools/gypv8sh.py
index 918368cbbfc991799f27e9be25c43b92888db4f2..7141f06eb9477b5a40afd51fe9153e8d563f37f1 100755
--- a/tools/gypv8sh.py
+++ b/tools/gypv8sh.py
@@ -33,9 +33,13 @@ def main ():
parser.error('all arguments are required.')
(v8_shell, mock_js, axs_testing_js, test_api, js2webui, test_type,
inputfile, inputrelfile, cxxoutfile, jsoutfile) = args
+ cmd = [v8_shell]
+ icudatafile = os.path.join(os.path.dirname(v8_shell), 'icudtl.dat')
+ if os.path.exists(icudatafile):
+ cmd.extend(['--icu-data-file=%s' % icudatafile])
arguments = [js2webui, inputfile, inputrelfile, cxxoutfile, test_type]
- cmd = [v8_shell, '-e', "arguments=" + json.dumps(arguments), mock_js,
- axs_testing_js, test_api, js2webui]
+ cmd.extend(['-e', "arguments=" + json.dumps(arguments), mock_js,
+ axs_testing_js, test_api, js2webui])
if opts.verbose or opts.impotent:
print cmd
if not opts.impotent:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698