Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: DEPS

Issue 2986943002: Revert "Remove "Windows toolchain" step from DEPS. May only be used by gyp." (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: DEPS
diff --git a/DEPS b/DEPS
index 16ebd4adb0396a06896fba2e3de379a610492c28..374fa1ffacf1799f5400692efa29d33d0e114420 100644
--- a/DEPS
+++ b/DEPS
@@ -33,6 +33,7 @@ vars = {
# "github_dartlang": "https://github.com/dart-lang/%s.git",
"co19_rev": "@dec2b67aaab3bb7339b9764049707e71e601da3d",
+ "gyp_rev": "@4801a5331ae62da9769a327f11c4213d32fb0dad",
# Revisions of GN related dependencies. This should match the revision
# pulled by Flutter.
@@ -139,6 +140,10 @@ vars = {
}
deps = {
+ # Stuff needed for GYP to run.
+ Var("dart_root") + "/third_party/gyp":
+ Var('chromium_git') + '/external/gyp.git' + Var("gyp_rev"),
+
# Stuff needed for GN build.
Var("dart_root") + "/buildtools":
Var("fuchsia_git") + "/buildtools" + Var("buildtools_revision"),
@@ -471,6 +476,12 @@ hooks = [
'pattern': '.',
'action': ['python', 'sdk/tools/buildtools/update.py'],
},
+ {
+ # Update the Windows toolchain if necessary.
+ 'name': 'win_toolchain',
+ 'pattern': '.',
+ 'action': ['python', 'sdk/build/vs_toolchain.py', 'update'],
+ },
{
"pattern": ".",
"action": ["python", Var("dart_root") + "/tools/generate_buildfiles.py"],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698