Issue 2986943002: Revert "Remove "Windows toolchain" step from DEPS. May only be used by gyp."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2986943002: Revert "Remove "Windows toolchain" step from DEPS. May only be used by gyp." (Closed)

Created:
3 years, 4 months ago by Bill Hesse

Modified:
3 years, 4 months ago

Reviewers:
phajdan, kustermann

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Remove "Windows toolchain" step from DEPS. May only be used by gyp." This reverts commit 5a8520ba91045b17ee6523aa7d46e3e7f23fd5d8. Also reverts removal of gyp from Dart DEPS. BUG= TBR=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/c1db164c8bff7eb434af9cdd3ff75f6c6a52a085

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	DEPS	View		3 chunks	+11 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Bill Hesse

Committed patchset #1 (id:1) manually as c1db164c8bff7eb434af9cdd3ff75f6c6a52a085 (presubmit successful).

3 years, 4 months ago (2017-07-27 11:54:49 UTC) #4

Message was sent while issue was closed.

lgtm