Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2986863002: Bump analyzer//front_end//kernel package versions. (Closed)

Created:
3 years, 5 months ago by pquitslund
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bump analyzer//front_end//kernel package versions. * bump alpha versions * update SDK constraints See: https://github.com/dart-lang/sdk/issues/30239 Closed in: https://codereview.chromium.org/2985103002/.

Patch Set 1 #

Total comments: 2

Patch Set 2 : constraint fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M pkg/analyzer/pubspec.yaml View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/pubspec.yaml View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/kernel/pubspec.yaml View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pquitslund
3 years, 5 months ago (2017-07-25 22:15:54 UTC) #2
scheglov
lgtm
3 years, 5 months ago (2017-07-25 22:17:34 UTC) #3
devoncarew
lgtm https://codereview.chromium.org/2986863002/diff/1/pkg/kernel/pubspec.yaml File pkg/kernel/pubspec.yaml (right): https://codereview.chromium.org/2986863002/diff/1/pkg/kernel/pubspec.yaml#newcode14 pkg/kernel/pubspec.yaml:14: analyzer: ^0.30.0 Expand to include 0.31.0? It's a ...
3 years, 5 months ago (2017-07-25 22:17:54 UTC) #4
pquitslund
https://codereview.chromium.org/2986863002/diff/1/pkg/kernel/pubspec.yaml File pkg/kernel/pubspec.yaml (right): https://codereview.chromium.org/2986863002/diff/1/pkg/kernel/pubspec.yaml#newcode14 pkg/kernel/pubspec.yaml:14: analyzer: ^0.30.0 On 2017/07/25 22:17:53, devoncarew wrote: > Expand ...
3 years, 5 months ago (2017-07-25 22:22:06 UTC) #5
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-07-26 13:36:32 UTC) #6
Brian Wilkerson
3 years, 4 months ago (2017-07-26 13:36:34 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698