Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 298683010: QUIC - Persist 1000 MRU alternate protocols to preferences file. (Closed)

Created:
6 years, 7 months ago by ramant (doing other things)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

QUIC - Persist 1000 MRU alternate protocols to preferences file. + Flip a coin and if we have persisted 1000 MRU servers, then load only either 200 or 1000 servers from disk. + Persist only one server (or don't duplicate server names) that spoke QUIC for canonical suffixes like: + .c.youtube.com + .googlevideo.com + Bumped up the version number of http_server_properties. + Added two histograms to measure the impact of persisting 1000 alternate protocol servers. ++ Net.AlternateProtocolUsage.200Truncated ++ Net.AlternateProtocolUsage.1000Truncated R=jar@chromium.org, rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272836

Patch Set 1 : Upload #

Total comments: 2

Patch Set 2 : Load 1000 MRU servers 1 in 1000 times - fix comments in patch set 1 #

Total comments: 2

Patch Set 3 : fixed rch's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -16 lines) Patch
M chrome/browser/net/http_server_properties_manager.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager.cc View 1 2 10 chunks +56 lines, -7 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_server_properties.h View 3 chunks +19 lines, -2 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +12 lines, -1 line 0 comments Download
M net/http/http_server_properties_impl.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 4 chunks +27 lines, -1 line 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
jar (doing other things)
LGTM % the change in randomization https://codereview.chromium.org/298683010/diff/20001/chrome/browser/net/http_server_properties_manager.cc File chrome/browser/net/http_server_properties_manager.cc (right): https://codereview.chromium.org/298683010/diff/20001/chrome/browser/net/http_server_properties_manager.cc#newcode367 chrome/browser/net/http_server_properties_manager.cc:367: if (base::RandInt(0, 1) ...
6 years, 7 months ago (2014-05-24 00:19:03 UTC) #1
ramant (doing other things)
https://codereview.chromium.org/298683010/diff/20001/chrome/browser/net/http_server_properties_manager.cc File chrome/browser/net/http_server_properties_manager.cc (right): https://codereview.chromium.org/298683010/diff/20001/chrome/browser/net/http_server_properties_manager.cc#newcode367 chrome/browser/net/http_server_properties_manager.cc:367: if (base::RandInt(0, 1) == 0) { On 2014/05/24 00:19:03, ...
6 years, 7 months ago (2014-05-24 00:34:06 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/298683010/diff/60001/chrome/browser/net/http_server_properties_manager.cc File chrome/browser/net/http_server_properties_manager.cc (right): https://codereview.chromium.org/298683010/diff/60001/chrome/browser/net/http_server_properties_manager.cc#newcode452 chrome/browser/net/http_server_properties_manager.cc:452: if (count < alternate_protocols_to_load) { perhaps: if (count ...
6 years, 7 months ago (2014-05-24 03:35:36 UTC) #3
ramant (doing other things)
https://codereview.chromium.org/298683010/diff/60001/chrome/browser/net/http_server_properties_manager.cc File chrome/browser/net/http_server_properties_manager.cc (right): https://codereview.chromium.org/298683010/diff/60001/chrome/browser/net/http_server_properties_manager.cc#newcode452 chrome/browser/net/http_server_properties_manager.cc:452: if (count < alternate_protocols_to_load) { On 2014/05/24 03:35:36, Ryan ...
6 years, 7 months ago (2014-05-25 05:07:32 UTC) #4
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 7 months ago (2014-05-25 05:07:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/298683010/80001
6 years, 7 months ago (2014-05-25 05:07:57 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 07:51:36 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 07:56:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77474)
6 years, 7 months ago (2014-05-25 07:56:45 UTC) #9
jar (doing other things)
On 2014/05/25 07:56:45, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-05-25 08:24:33 UTC) #10
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 7 months ago (2014-05-25 14:20:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/298683010/80001
6 years, 7 months ago (2014-05-25 14:20:35 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 14:25:25 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 14:32:05 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77494)
6 years, 7 months ago (2014-05-25 14:32:05 UTC) #15
jar (doing other things)
The CQ bit was checked by jar@chromium.org
6 years, 7 months ago (2014-05-25 16:29:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/298683010/80001
6 years, 7 months ago (2014-05-25 16:29:48 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 16:35:44 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 16:40:41 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77501)
6 years, 7 months ago (2014-05-25 16:40:41 UTC) #20
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 7 months ago (2014-05-26 01:41:07 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/298683010/80001
6 years, 7 months ago (2014-05-26 01:41:38 UTC) #22
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 16:06:52 UTC) #23
Message was sent while issue was closed.
Change committed as 272836

Powered by Google App Engine
This is Rietveld 408576698