Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: experimental/benchtools/greenify.py

Issue 298683004: fix some bench rebase tool problems. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: copyright etc. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | experimental/benchtools/rebase.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/benchtools/greenify.py
diff --git a/experimental/benchtools/greenify.py b/experimental/benchtools/greenify.py
index 913a63ffd54dd5d965b368a85ced253c6843d072..8d77abd3fdabe7c2e751875a10a17136427df98f 100755
--- a/experimental/benchtools/greenify.py
+++ b/experimental/benchtools/greenify.py
@@ -1,11 +1,20 @@
-#!/usr/bin/python2.7
+#!/usr/bin/env python
+
+
+# Copyright (c) 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
"""greenify.py: standalone script to correct flaky bench expectations.
- Usage:
- Copy script to a separate dir outside Skia repo. The script will create a
- skia dir on the first run to host the repo, and will create/delete temp
- dirs as needed.
- ./greenify.py --url <the stdio url from failed CheckForRegressions step>
+
+ Requires Rietveld credentials on the running machine.
+
+ Usage:
+ Copy script to a separate dir outside Skia repo. The script will create a
+ skia dir on the first run to host the repo, and will create/delete
+ temp dirs as needed.
+ ./greenify.py --url <the stdio url from failed CheckForRegressions step>
"""
import argparse
@@ -147,8 +156,6 @@ def main():
print 'Please copy script to a separate dir outside git repos to use.'
return
ts_str = '%s' % time.time()
- exp_dir = os.path.join(d, 'exp' + ts_str)
- clean_dir(exp_dir)
parser = argparse.ArgumentParser()
parser.add_argument('--url',
@@ -180,6 +187,8 @@ def main():
if args.commit:
commit = True
+ exp_dir = os.path.join(d, 'exp' + ts_str)
+ clean_dir(exp_dir)
if not widen_bench_ranges(args.url, bot, repo_dir, exp_dir):
print 'NO bench exceptions found! %s' % args.url
elif not git_commit_expectations(
« no previous file with comments | « no previous file | experimental/benchtools/rebase.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698