Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2986803002: [Fuchsia] Fixes and cleanup for launchpad_vmo_from_file() deprecation (Closed)

Created:
3 years, 4 months ago by zra
Modified:
3 years, 4 months ago
Reviewers:
swetland, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Fuchsia] Fixes and cleanup for launchpad_vmo_from_file() deprecation R=rmacnak@google.com, swetland@google.com Committed: https://github.com/dart-lang/sdk/commit/4b752eaf05fbc8d3c82ae0604babc1bf8867105f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -33 lines) Patch
M runtime/bin/extensions_fuchsia.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M runtime/bin/process_fuchsia.cc View 2 chunks +19 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 4 months ago (2017-07-24 15:56:39 UTC) #2
swetland
On 2017/07/24 15:56:39, zra wrote: LGTM
3 years, 4 months ago (2017-07-24 18:29:14 UTC) #3
rmacnak
lgtm
3 years, 4 months ago (2017-07-24 19:30:28 UTC) #4
zra
3 years, 4 months ago (2017-07-24 20:32:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b752eaf05fbc8d3c82ae0604babc1bf8867105f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698