Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2986673002: Fix getSetterType in presence of metadata (Closed)

Created:
3 years, 5 months ago by vsm
Modified:
3 years, 5 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/dev_compiler/test/compile_error_tests.dart View 1 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tests/lib_strong/mirrors/field_metadata_test.dart View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vsm
3 years, 5 months ago (2017-07-21 18:10:12 UTC) #2
Jennifer Messerly
lgtm
3 years, 5 months ago (2017-07-21 20:32:16 UTC) #3
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-21 22:04:13 UTC) #4
vsm
3 years, 5 months ago (2017-07-24 02:56:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
19a19f4423a9b8bc85fcd8cf9e5dd9d4218990d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698