Issue 2986583002: Reapply "Add nonboxed closure class fields."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2986583002: Reapply "Add nonboxed closure class fields." (Closed)

Created:
3 years, 5 months ago by Emily Fortuna

Modified:
3 years, 5 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Reapply "Add nonboxed closure class fields." Last time I submitted it I was unable to test my adjustments from sra's suggestions becuase of build permissions (and failed motherboard). It has been tested on my laptop now. This reverts commit bff25c89fe8de6874c8f289bb255d5b10db23fef. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/306453d91d7d225445f4ae3031f516f3cc534d5f

Patch Set 1 #

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -51 lines)			Patch
M	pkg/compiler/lib/src/js_model/closure.dart	View	14 chunks	+165 lines, -50 lines	0 comments	Download
M	pkg/compiler/lib/src/js_model/closure_visitors.dart	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map_impl.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Emily Fortuna

3 years, 5 months ago (2017-07-20 19:15:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
306453d91d7d225445f4ae3031f516f3cc534d5f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages