Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2316)

Unified Diff: pkg/kernel/lib/transformations/closure/info.dart

Issue 2986553002: Remove dead code for closure-converting tearoffs. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/transformations/closure/converter.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/transformations/closure/info.dart
diff --git a/pkg/kernel/lib/transformations/closure/info.dart b/pkg/kernel/lib/transformations/closure/info.dart
index 8d6645b8edb64e5b91e3a169d3871022972c447d..670dbb0dbc21aac99fb8658a2be3193c97ad0f40 100644
--- a/pkg/kernel/lib/transformations/closure/info.dart
+++ b/pkg/kernel/lib/transformations/closure/info.dart
@@ -62,24 +62,6 @@ class ClosureInfo extends RecursiveVisitor {
return currentFunction == null || currentMemberFunction == currentFunction;
}
- /// Maps the names of all instance methods that may be torn off (aka
- /// implicitly closurized) to `${name.name}#get`.
- Map<Name, Name> get tearOffGetterNames {
- // TODO(dmitryas): Add support for tear-offs. When added, uncomment this.
- //
- // Map<Name, Name> result = <Name, Name>{};
- // for (Name name in declaredInstanceMethodNames) {
- // if (invokedGetters.contains(name)) {
- // result[name] = new Name("${name.name}#get", name.library);
- // }
- // }
- // return result;
- //
- // Currently an empty map is returned, so no tear-offs supporting functions
- // and getters are generated, and no property-get targets are renamed.
- return <Name, Name>{};
- }
-
Dmitry Stefantsov 2017/07/20 13:37:06 You probably may want to remove [invokedGetters] a
sjindel 2017/07/20 13:45:46 Done.
void beginMember(Member member, [FunctionNode function]) {
currentMemberLocalNames.clear();
if (function != null) {
« no previous file with comments | « pkg/kernel/lib/transformations/closure/converter.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698