Remove dead code for closure-converting tearoffs.

Remove dead code for closure-converting tearoffs.

This review scraps the (currently disabled) code for converting tearoffs in the
closure conversion pass.

The closure conversion pass can only ever do a partial job with tearoffs, due to
the possibility of an unconverted library tearing off a method from any object
it likes. Partially converting [PropertyGet]s makes the closure conversion pass
slower and introduces a new method for any field or method anywhere with a name
used in any [PropertyGet], inflating code size and potentially regressing
performance. As it provides no concrete value in return we've decided to scrap
this aspect of the transformation. Anyway, creating closures for tearoffs is
much easier for a backend than converting anonymous or nested functions, since
there is only one object ("this") captured. Thus ignoring tear-offs does not
undermine the value of the transformation.

BUG=
R=dmitryas@google.com

Committed: https://github.com/dart-lang/sdk/commit/239e04487487759d8d859bdc104e983375bb4c7b

[sjindel, 2017-07-20 12:58:19]

Description was changed from

==========
Remove dead code for closure-converting tearoffs.

This review scraps the (currently disabled) code for converting tearoffs in the
closure conversion pass.

The closure conversion pass can only ever do a partial job with tearoffs, due to
the possibility of an unconverted library tearing off a method from any object
it likes. Partially converting [PropertyGet]s makes the closure conversion pass
slower and introduces a new method for any field or method anywhere with a name
used in any [PropertyGet], inflating code size and potentially regressing
performance. As it provides no concrete value in return we've decided to scrap
this aspect of the transformation. Anyway, creating closures for tearoffs is
much easier for a backend than converting anonymous or nested functions, since
there is only one object ("this") captured. Thus ignoring tear-offs does not
undermine the value of the transformation.

BUG=
==========

to

==========
Remove dead code for closure-converting tearoffs.

This review scraps the (currently disabled) code for converting tearoffs in the
closure conversion pass.

The closure conversion pass can only ever do a partial job with tearoffs, due to
the possibility of an unconverted library tearing off a method from any object
it likes. Partially converting [PropertyGet]s makes the closure conversion pass
slower and introduces a new method for any field or method anywhere with a name
used in any [PropertyGet], inflating code size and potentially regressing
performance. As it provides no concrete value in return we've decided to scrap
this aspect of the transformation. Anyway, creating closures for tearoffs is
much easier for a backend than converting anonymous or nested functions, since
there is only one object ("this") captured. Thus ignoring tear-offs does not
undermine the value of the transformation.

BUG=
==========

[sjindel, 2017-07-20 12:58:20]

sjindel@google.com changed reviewers:
+ dmitryas@google.com

[Dmitry Stefantsov, 2017-07-20 13:37:06]

https://codereview.chromium.org/2986553002/diff/1/pkg/kernel/lib/transformati...
File pkg/kernel/lib/transformations/closure/info.dart (left):

https://codereview.chromium.org/2986553002/diff/1/pkg/kernel/lib/transformati...
pkg/kernel/lib/transformations/closure/info.dart:82: 
You probably may want to remove [invokedGetters] and
[declaredInstanceMethodNames] as well as the accompanying code.

[sjindel, 2017-07-20 13:45:47]

https://codereview.chromium.org/2986553002/diff/1/pkg/kernel/lib/transformati...
File pkg/kernel/lib/transformations/closure/info.dart (left):

https://codereview.chromium.org/2986553002/diff/1/pkg/kernel/lib/transformati...
pkg/kernel/lib/transformations/closure/info.dart:82: 
On 2017/07/20 13:37:06, Dmitry Stefantsov wrote:
> You probably may want to remove [invokedGetters] and
> [declaredInstanceMethodNames] as well as the accompanying code.

Done.

[Dmitry Stefantsov, 2017-07-20 13:51:07]

LGTM

[sjindel, 2017-07-20 14:47:14]

Description was changed from

==========
Remove dead code for closure-converting tearoffs.

This review scraps the (currently disabled) code for converting tearoffs in the
closure conversion pass.

The closure conversion pass can only ever do a partial job with tearoffs, due to
the possibility of an unconverted library tearing off a method from any object
it likes. Partially converting [PropertyGet]s makes the closure conversion pass
slower and introduces a new method for any field or method anywhere with a name
used in any [PropertyGet], inflating code size and potentially regressing
performance. As it provides no concrete value in return we've decided to scrap
this aspect of the transformation. Anyway, creating closures for tearoffs is
much easier for a backend than converting anonymous or nested functions, since
there is only one object ("this") captured. Thus ignoring tear-offs does not
undermine the value of the transformation.

BUG=
==========

to

==========
Remove dead code for closure-converting tearoffs.

This review scraps the (currently disabled) code for converting tearoffs in the
closure conversion pass.

The closure conversion pass can only ever do a partial job with tearoffs, due to
the possibility of an unconverted library tearing off a method from any object
it likes. Partially converting [PropertyGet]s makes the closure conversion pass
slower and introduces a new method for any field or method anywhere with a name
used in any [PropertyGet], inflating code size and potentially regressing
performance. As it provides no concrete value in return we've decided to scrap
this aspect of the transformation. Anyway, creating closures for tearoffs is
much easier for a backend than converting anonymous or nested functions, since
there is only one object ("this") captured. Thus ignoring tear-offs does not
undermine the value of the transformation.

BUG=
R=dmitryas@google.com

Committed:
https://github.com/dart-lang/sdk/commit/239e04487487759d8d859bdc104e983375bb4c7b
==========

[sjindel, 2017-07-20 14:47:16]

Committed patchset #2 (id:20001) manually as
239e04487487759d8d859bdc104e983375bb4c7b (presubmit successful).