Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 298653011: More ChromeVox tests (Closed)

Created:
6 years, 7 months ago by dmazzoni
Modified:
6 years, 6 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

More ChromeVox tests BUG=371692 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275481

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Update and temporarily remove one that doesn't pass anymore #

Total comments: 8

Patch Set 4 : Address nits #

Patch Set 5 : Fix style violations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7237 lines, -5 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/common/cursor_selection_test.js View 1 2 1 chunk +97 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/common/editable_text_area_shadow_test.js View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.js View 1 2 3 1 chunk +445 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/common/math_semantic_tree_test.js View 1 2 3 4 1 chunk +6188 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/common/selection_util_test.js View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/host/testing/earcons.js View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/host/testing/host.js View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/host/testing/mathjax.js View 1 chunk +71 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/host/testing/msgs.js View 1 2 3 4 1 chunk +86 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/host/testing/tts.js View 1 2 3 4 1 chunk +108 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js View 1 2 3 4 2 chunks +90 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dmazzoni
6 years, 7 months ago (2014-05-23 22:01:24 UTC) #1
Peter Lundblad
When you have time, please move to the new chromevox_tests target and I'll review after ...
6 years, 6 months ago (2014-06-06 15:26:21 UTC) #2
dmazzoni
Done. One test suite doesn't pass anymore so I removed it for now so we ...
6 years, 6 months ago (2014-06-06 16:53:18 UTC) #3
Peter Lundblad
lgtm Just nits. https://codereview.chromium.org/298653011/diff/40001/chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.js File chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.js (right): https://codereview.chromium.org/298653011/diff/40001/chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.js#newcode81 chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.js:81: /** Sets up class wide test ...
6 years, 6 months ago (2014-06-06 17:33:03 UTC) #4
dmazzoni
https://codereview.chromium.org/298653011/diff/40001/chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.js File chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.js (right): https://codereview.chromium.org/298653011/diff/40001/chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.js#newcode81 chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.js:81: /** Sets up class wide test data, including mocks ...
6 years, 6 months ago (2014-06-06 18:05:12 UTC) #5
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 6 months ago (2014-06-06 18:18:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/298653011/80001
6 years, 6 months ago (2014-06-06 18:20:03 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 18:21:48 UTC) #8
Message was sent while issue was closed. 
Change committed as 275481

Powered by Google App Engine
This is Rietveld 408576698