Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2986523002: Correct assertions for validating layout of Closure objects (Closed)

Created:
3 years, 5 months ago by alexmarkov
Modified:
3 years, 5 months ago
Reviewers:
zra, rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Correct assertions for validating layout of Closure objects These assertions in bootstrap_nocore.cc are complete duplicates of the ones in bootstrap.cc and should be adjusted accordingly after the layout of Closure was changed. Follow-up for the https://codereview.chromium.org/2983823002/ R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/b1215faa59a7e9bb7eed3b142ad7f3fa7581349c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/vm/bootstrap_nocore.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
alexmarkov
3 years, 5 months ago (2017-07-19 23:52:11 UTC) #4
siva
lgtm
3 years, 5 months ago (2017-07-19 23:54:34 UTC) #5
alexmarkov
3 years, 5 months ago (2017-07-19 23:56:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1215faa59a7e9bb7eed3b142ad7f3fa7581349c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698