Issue 2986513002: Pass shared options to dartdevc in test.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2986513002: Pass shared options to dartdevc in test.dart. (Closed)

Created:
3 years, 5 months ago by Bob Nystrom

Modified:
3 years, 5 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, bkonyi

Target Ref:
refs/heads/master

Visibility:
Public.

Pass shared options to dartdevc in test.dart. This fixes the from_environment tests. Before, DDC wasn't getting passed the names being defined. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/18ba6eb06dc0737d568ad3086062626749734ca7

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -10 lines)			Patch
M	tests/corelib_2/corelib_2.status	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	tools/testing/dart/compiler_configuration.dart	View		4 chunks	+26 lines, -6 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

3 years, 5 months ago (2017-07-20 00:06:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
18ba6eb06dc0737d568ad3086062626749734ca7 (presubmit successful).