Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2986503002: Migrate test block 4 to Dart 2.0. (Closed)

Created:
3 years, 5 months ago by jcollins
Modified:
3 years, 5 months ago
Reviewers:
*Bob Nystrom, bkonyi
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate test block 4 to Dart 2.0. Unusual things in this block: - corelib_strong/data_uri_test.dart was behind corelib, so migrated that file from corelib. - core_runtime_types_test was split per the document into static and non-static versions - data_resource_test.dart is now pointless since class Resource was moved from dart:core to http://github.com/dart-lang/resource, so deleted. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/b1da48a29de7e3d359ff8b841701492c58e4c0ef

Patch Set 1 #

Patch Set 2 : Merge with head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1957 lines) Patch
D tests/corelib/compare_to_test.dart View 1 chunk +0 lines, -136 lines 0 comments Download
D tests/corelib/const_list_literal_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D tests/corelib/const_list_remove_range_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib/const_list_set_range_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/corelib/core_runtime_types_test.dart View 1 chunk +0 lines, -342 lines 0 comments Download
M tests/corelib/corelib.status View 1 3 chunks +0 lines, -5 lines 0 comments Download
D tests/corelib/data_uri_test.dart View 1 chunk +0 lines, -335 lines 0 comments Download
A + tests/corelib_2/compare_to_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/const_list_literal_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/const_list_remove_range_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/const_list_set_range_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/corelib_2/core_runtime_types_static_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A + tests/corelib_2/core_runtime_types_test.dart View 2 chunks +0 lines, -19 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 3 chunks +15 lines, -0 lines 0 comments Download
A + tests/corelib_2/data_uri_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/corelib_strong/compare_to_test.dart View 1 chunk +0 lines, -136 lines 0 comments Download
D tests/corelib_strong/const_list_literal_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D tests/corelib_strong/const_list_remove_range_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib_strong/const_list_set_range_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/corelib_strong/core_runtime_types_test.dart View 1 chunk +0 lines, -342 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 2 chunks +0 lines, -9 lines 0 comments Download
D tests/corelib_strong/data_resource_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/corelib_strong/data_uri_test.dart View 1 chunk +0 lines, -271 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jcollins
3 years, 5 months ago (2017-07-19 21:31:29 UTC) #3
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-20 00:10:12 UTC) #5
jcollins
Committed patchset #2 (id:20001) manually as b1da48a29de7e3d359ff8b841701492c58e4c0ef (presubmit successful).
3 years, 5 months ago (2017-07-21 15:24:35 UTC) #7
jcollins
3 years, 5 months ago (2017-07-21 15:41:11 UTC) #8
Message was sent while issue was closed.
On 2017/07/21 15:24:35, jcollins wrote:
> Committed patchset #2 (id:20001) manually as
> b1da48a29de7e3d359ff8b841701492c58e4c0ef (presubmit successful).

This seems to have broken the bots despite my testing, looking at it now.

Powered by Google App Engine
This is Rietveld 408576698