Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: runtime/vm/dart.cc

Issue 2986463002: Fix Flutter engine build (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart.cc
diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc
index 3949b8b51bdd18fe013d054b835201a33f3ee0d1..c836a5064da75cdcf118957057ee53570c6d7b27 100644
--- a/runtime/vm/dart.cc
+++ b/runtime/vm/dart.cc
@@ -605,23 +605,23 @@ RawError* Dart::InitializeIsolate(const uint8_t* snapshot_data,
}
bool is_kernel_isolate = false;
+ USE(is_kernel_isolate);
+
#ifndef DART_PRECOMPILED_RUNTIME
KernelIsolate::InitCallback(I);
is_kernel_isolate = KernelIsolate::IsKernelIsolate(I);
#endif
- ServiceIsolate::MaybeMakeServiceIsolate(I);
+
#if !defined(PRODUCT)
+ ServiceIsolate::MaybeMakeServiceIsolate(I);
rmacnak 2017/07/19 16:56:36 I would leave this line in. The standalone embedde
if (!ServiceIsolate::IsServiceIsolate(I) && !is_kernel_isolate) {
I->message_handler()->set_should_pause_on_start(
FLAG_pause_isolates_on_start);
I->message_handler()->set_should_pause_on_exit(FLAG_pause_isolates_on_exit);
}
-#endif // !defined(PRODUCT)
-
ServiceIsolate::SendIsolateStartupMessage();
-#if !defined(PRODUCT)
I->debugger()->NotifyIsolateCreated();
-#endif
+#endif // !defined(PRODUCT)
// Create tag table.
I->set_tag_table(GrowableObjectArray::Handle(GrowableObjectArray::New()));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698