Issue 2986463002: Fix Flutter engine build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2986463002: Fix Flutter engine build (Closed)

Created:
3 years, 5 months ago by zra

Modified:
3 years, 5 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix Flutter engine build Fixes an unused variable error in android_release. Committed: https://github.com/dart-lang/sdk/commit/5258cbec1016300cb535c6e7e0978d64deac5780

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix Flutter engine build #

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	runtime/vm/dart.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

Committed patchset #2 (id:20001) manually as 5258cbec1016300cb535c6e7e0978d64deac5780 (presubmit successful).

3 years, 5 months ago (2017-07-19 16:55:56 UTC) #5

rmacnak

3 years, 5 months ago (2017-07-19 16:56:37 UTC) #6

Message was sent while issue was closed.

I'm seeing 

../../runtime/vm/runtime_entry.cc:1627:8: error: variable 'do_stacktrace' set
but not used [-Werror=unused-but-set-variable]
   bool do_stacktrace = false;

for ninja.py -aia32 -mproduct runtime_precompiled

https://codereview.chromium.org/2986463002/diff/1/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/2986463002/diff/1/runtime/vm/dart.cc#newcode616
runtime/vm/dart.cc:616: ServiceIsolate::MaybeMakeServiceIsolate(I);
I would leave this line in. The standalone embedder still starts the service
isolate in product mode to use as the loader.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages