Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2986403002: Test type inference for field initializers using "this." syntax. (Closed)

Created:
3 years, 4 months ago by Paul Berry
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test type inference for field initializers using "this." syntax. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/867d682ff511f7daf94642d9be8ee8755e9bd147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M pkg/front_end/testcases/ast_builder.status View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_this.dart View 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_this.dart.direct.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_this.dart.outline.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_this.dart.strong.expect View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 4 months ago (2017-08-03 21:08:14 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-03 21:09:33 UTC) #3
Paul Berry
3 years, 4 months ago (2017-08-03 21:32:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
867d682ff511f7daf94642d9be8ee8755e9bd147 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698