Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: pkg/kernel/lib/binary/ast_from_binary.dart

Issue 2986393002: Record Typedef reference into Kernel FunctionType and resynthesyze typedefs in Analyzer. (Closed)
Patch Set: Drop @informative for typedefReference. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/binary/ast_from_binary.dart
diff --git a/pkg/kernel/lib/binary/ast_from_binary.dart b/pkg/kernel/lib/binary/ast_from_binary.dart
index 1c5814732cf40491323070944450d99d2482e72a..b7a7113693733cd48c7bf45556ce245d8d1e823a 100644
--- a/pkg/kernel/lib/binary/ast_from_binary.dart
+++ b/pkg/kernel/lib/binary/ast_from_binary.dart
@@ -343,7 +343,7 @@ class BinaryBuilder {
}
Reference readTypedefReference() {
- return readCanonicalNameReference().getReference();
+ return readCanonicalNameReference()?.getReference();
}
Name readName() {
@@ -1176,6 +1176,7 @@ class BinaryBuilder {
var positional = readDartTypeList();
var named = readNamedTypeList();
var positionalNames = readStringReferenceList();
+ var typedefReference = readTypedefReference();
assert(positional.length + named.length == totalParameterCount);
var returnType = readDartType();
typeParameterStack.length = typeParameterStackHeight;
@@ -1183,7 +1184,8 @@ class BinaryBuilder {
typeParameters: typeParameters,
requiredParameterCount: requiredParameterCount,
namedParameters: named,
- positionalParameterNames: positionalNames);
+ positionalParameterNames: positionalNames,
+ typedefReference: typedefReference);
case Tag.SimpleFunctionType:
var positional = readDartTypeList();
var positionalNames = readStringReferenceList();
« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698