Issue 298633002: Version 3.25.28.18 (merged r20967)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 298633002: Version 3.25.28.18 (merged r20967) (Closed)

Created:
6 years, 7 months ago by mvstanton

Modified:
6 years, 7 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.25

Visibility:
Public.

More Reviews

Description

Version 3.25.28.18 (merged r20967) Don't adopt the AST id from previous if id is none, since previous may have mismatching expected stack height. Additionally, harden merging of simulates after instructions with side effects and ensure there's a simulate before HEnterInlined. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21371

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -19 lines)			Patch
M	src/hydrogen-instructions.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/hydrogen-removable-simulates.cc	View	2 chunks	+27 lines, -13 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-lazy-deopt-inlining2.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r21371.

Expand Messages | Collapse Messages