DescriptionUpdate the integration tests in preparation for Clang.
There's 2 way to pass some options to the SyzyAsan runtime:
- At instrumentation time by specifying them on the command line
(e.g.: 'instrument.exe --mode=asan --asan-rtl-options="--foo --bar")
- At runtime via an environment variable (SYZYGY_ASAN_OPTIONS)
Only the environment variable approach works with Clang (yet, we might
consider making it possible to specify these options at instrumentation
time one day).
Most of the tests are failing with the Clang instrumented version of
the test DLL because they rely on the Asan options passed on the
command line at instrumentation time, there's no particular reason for
this except that it was cleaner than messing up with environment
variables. As we want to support Clang we'll need to switch to using
the env-var method.
Review-Url: https://codereview.chromium.org/2986323003
Committed: https://github.com/google/syzygy/commit/22eea4e8748ce2ec1f1497691f0ada84390aed2d
Patch Set 1 #Patch Set 2 : Fixes #Patch Set 3 : nits #
Total comments: 2
Patch Set 4 : Address Siggi's comment. #
Total comments: 2
Patch Set 5 : Address Siggi's comment. #
Messages
Total messages: 19 (12 generated)
|