Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2986153002: Fix some test suppressions for Chrome 60 (Closed)

Created:
3 years, 4 months ago by Alan Knight
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix the matching lib_strong test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M tests/co19/co19-dart2js.status View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/html/html.status View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/html/indexeddb_1_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/lib_strong/html/indexeddb_1_test.dart View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Alan Knight
TBR In addition to fixing suppressions, deleted the supportsDatabaseName test. That API is no longer ...
3 years, 4 months ago (2017-07-28 18:46:52 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 4 months ago (2017-07-28 19:10:28 UTC) #3
Alan Knight
3 years, 4 months ago (2017-07-28 19:39:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4c9b6c843782689143eb2d072279f907e8200f7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698