Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart

Issue 2986093002: Revert two Kernel changes that were causing test failures. (Closed)
Patch Set: Revert "Migrate language/async_backwards... ... language/async_star_take..." Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
index 5da69b667122d097700b568ebf3f0fc80553e1bd..27d69152aaec93f9db813f856a41a7b87e9819b6 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
@@ -81,7 +81,6 @@ abstract class KernelFunctionBuilder
Statement actualBody;
KernelFunctionBuilder(
- String documentationComment,
List<MetadataBuilder> metadata,
int modifiers,
KernelTypeBuilder returnType,
@@ -91,8 +90,8 @@ abstract class KernelFunctionBuilder
KernelLibraryBuilder compilationUnit,
int charOffset,
this.nativeMethodName)
- : super(documentationComment, metadata, modifiers, returnType, name,
- typeVariables, formals, compilationUnit, charOffset);
+ : super(metadata, modifiers, returnType, name, typeVariables, formals,
+ compilationUnit, charOffset);
void set body(Statement newBody) {
if (newBody != null) {
@@ -208,7 +207,6 @@ class KernelProcedureBuilder extends KernelFunctionBuilder {
final ConstructorReferenceBuilder redirectionTarget;
KernelProcedureBuilder(
- String documentationComment,
List<MetadataBuilder> metadata,
int modifiers,
KernelTypeBuilder returnType,
@@ -226,17 +224,8 @@ class KernelProcedureBuilder extends KernelFunctionBuilder {
fileUri: compilationUnit?.relativeFileUri)
..fileOffset = charOffset
..fileEndOffset = charEndOffset,
- super(
- documentationComment,
- metadata,
- modifiers,
- returnType,
- name,
- typeVariables,
- formals,
- compilationUnit,
- charOffset,
- nativeMethodName);
+ super(metadata, modifiers, returnType, name, typeVariables, formals,
+ compilationUnit, charOffset, nativeMethodName);
ProcedureKind get kind => procedure.kind;
@@ -287,7 +276,6 @@ class KernelProcedureBuilder extends KernelFunctionBuilder {
procedure.isExternal = isExternal;
procedure.isConst = isConst;
procedure.name = new Name(name, library.target);
- procedure.documentationComment = documentationComment;
}
if (isEligibleForTopLevelInference) {
library.loader.typeInferenceEngine.recordMember(procedure);
@@ -322,7 +310,6 @@ class KernelConstructorBuilder extends KernelFunctionBuilder {
RedirectingInitializer redirectingInitializer;
KernelConstructorBuilder(
- String documentationComment,
List<MetadataBuilder> metadata,
int modifiers,
KernelTypeBuilder returnType,
@@ -337,17 +324,8 @@ class KernelConstructorBuilder extends KernelFunctionBuilder {
: constructor = new Constructor(null)
..fileOffset = charOffset
..fileEndOffset = charEndOffset,
- super(
- documentationComment,
- metadata,
- modifiers,
- returnType,
- name,
- typeVariables,
- formals,
- compilationUnit,
- charOffset,
- nativeMethodName);
+ super(metadata, modifiers, returnType, name, typeVariables, formals,
+ compilationUnit, charOffset, nativeMethodName);
bool get isInstanceMember => false;
@@ -370,7 +348,6 @@ class KernelConstructorBuilder extends KernelFunctionBuilder {
constructor.isConst = isConst;
constructor.isExternal = isExternal;
constructor.name = new Name(name, library.target);
- constructor.documentationComment = documentationComment;
}
return constructor;
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_target.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698