Partial support for intelligent paste operation

Partial support for intelligent paste operation

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/9591a9449f28c9c39c68928d9576e518046e94cb

[Brian Wilkerson, 2017-07-27 20:21:44]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-07-27 20:21:44]

I want to refactor the implementation to move a large portion of it into the
ChangeBuilder framework, but this seemed like a good time to get another pair of
eyes on both the overall approach and the tests.

[scheglov, 2017-07-27 20:54:15]

LGTM

https://codereview.chromium.org/2986073002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/computer/import_elements_computer.dart (right):

https://codereview.chromium.org/2986073002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/computer/import_elements_computer.dart:56:
SourceFactory sourceFactory = libraryElement.context.sourceFactory;
It might be worth eventually to expose SourceFactory from AnalysisSession.
With the final goal to remove AnalysisContext.

[Brian Wilkerson, 2017-07-27 20:55:33]

https://codereview.chromium.org/2986073002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/computer/import_elements_computer.dart (right):

https://codereview.chromium.org/2986073002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/computer/import_elements_computer.dart:56:
SourceFactory sourceFactory = libraryElement.context.sourceFactory;
I agree. I'll try to tackle that soon.

[Brian Wilkerson, 2017-07-27 20:56:02]

Description was changed from

==========
Partial support for intelligent paste operation
==========

to

==========
Partial support for intelligent paste operation

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9591a9449f28c9c39c68928d9576e518046e94cb
==========

[Brian Wilkerson, 2017-07-27 20:56:05]

Committed patchset #2 (id:20001) manually as
9591a9449f28c9c39c68928d9576e518046e94cb (presubmit successful).