Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: pkg/analyzer/test/src/task/strong/strong_test_helper.dart

Issue 2986063002: Avoid issuing incorrect errors when super mixins are enabled (Closed)
Patch Set: Address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/task/strong/inferred_type_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/strong/strong_test_helper.dart
diff --git a/pkg/analyzer/test/src/task/strong/strong_test_helper.dart b/pkg/analyzer/test/src/task/strong/strong_test_helper.dart
index c4c461e97240fc5edf097ea18ac4f2e7b98396ab..578cf8c05c5fda7994a540c1b4494f49afa23083 100644
--- a/pkg/analyzer/test/src/task/strong/strong_test_helper.dart
+++ b/pkg/analyzer/test/src/task/strong/strong_test_helper.dart
@@ -273,8 +273,8 @@ class AbstractStrongTest {
{bool declarationCasts: true,
bool implicitCasts: true,
bool implicitDynamic: true,
- List<String> nonnullableTypes:
- AnalysisOptionsImpl.NONNULLABLE_TYPES}) async {
+ List<String> nonnullableTypes: AnalysisOptionsImpl.NONNULLABLE_TYPES,
+ bool superMixins: false}) async {
_checkCalled = true;
File mainFile =
@@ -288,6 +288,7 @@ class AbstractStrongTest {
analysisOptions.implicitCasts = implicitCasts;
analysisOptions.implicitDynamic = implicitDynamic;
analysisOptions.nonnullableTypes = nonnullableTypes;
+ analysisOptions.enableSuperMixins = superMixins;
var mockSdk = new MockSdk(resourceProvider: _resourceProvider);
mockSdk.context.analysisOptions = analysisOptions;
@@ -363,9 +364,19 @@ class AbstractStrongTest {
/// Adds a file using [addFile] and calls [check].
///
/// Also returns the resolved compilation unit.
- Future<CompilationUnit> checkFile(String content) async {
+ Future<CompilationUnit> checkFile(String content,
+ {bool declarationCasts: true,
+ bool implicitCasts: true,
+ bool implicitDynamic: true,
+ List<String> nonnullableTypes: AnalysisOptionsImpl.NONNULLABLE_TYPES,
+ bool superMixins: false}) async {
addFile(content);
- return check();
+ return check(
+ declarationCasts: declarationCasts,
+ implicitCasts: implicitCasts,
+ implicitDynamic: implicitDynamic,
+ nonnullableTypes: nonnullableTypes,
+ superMixins: superMixins);
}
void setUp() {
« no previous file with comments | « pkg/analyzer/test/src/task/strong/inferred_type_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698