[scheduler]: ACLs phase 1 - per Job ACL specification and enforcement.

scheduler/appengine/apiservers/scheduler_test.go

 // Copyright 2017 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 34 matching lines @@
         t.Parallel()
 
         Convey("Scheduler GetJobs API works", t, func() {
                 ctx := gaetesting.TestingContext()
                 fakeEng, catalog := newTestEngine()
                 fakeTaskBlob, err := registerUrlFetcher(catalog)
                 So(err, ShouldBeNil)
                 ss := SchedulerServer{fakeEng, catalog}
 
                 Convey("Empty", func() {
-                        fakeEng.getAllJobs = func() ([]*engine.Job, error) { return []*engine.Job{}, nil }
+                        fakeEng.getAllJobsRA = func() ([]*engine.Job, error) { return []*engine.Job{}, nil }
                         reply, err := ss.GetJobs(ctx, nil)
                         So(err, ShouldBeNil)
                         So(len(reply.GetJobs()), ShouldEqual, 0)
                 })
 
                 Convey("All Projects", func() {
-                        fakeEng.getAllJobs = func() ([]*engine.Job, error) {
+                        fakeEng.getAllJobsRA = func() ([]*engine.Job, error) {
                                 return []*engine.Job{
                                         {
                                                 JobID:     "bar/foo",
                                                 ProjectID: "bar",
                                                 Schedule:  "0 * * * * * *",
                                                 State:     engine.JobState{State: engine.JobStateRunning},
                                                 Task:      fakeTaskBlob,
                                         },
                                         {
                                                 JobID:     "baz/faz",
@@ skipping 17 matching lines @@
                                 {
                                         JobRef:   &scheduler.JobRef{Job: "faz", Project: "baz"},
                                         Schedule: "with 1m interval",
                                         State:    &scheduler.JobState{UiStatus: "PAUSED"},
                                         Paused:   true,
                                 },
                         })
                 })
 
                 Convey("One Project", func() {
-                        fakeEng.getProjectJobs = func(projectID string) ([]*engine.Job, error) {
+                        fakeEng.getProjectJobsRA = func(projectID string) ([]*engine.Job, error) {
                                 So(projectID, ShouldEqual, "bar")
                                 return []*engine.Job{
                                         {
                                                 JobID:     "bar/foo",
                                                 ProjectID: "bar",
                                                 Schedule:  "0 * * * * * *",
                                                 State:     engine.JobState{State: engine.JobStateRunning},
                                                 Task:      fakeTaskBlob,
                                         },
                                 }, nil
                         }
                         reply, err := ss.GetJobs(ctx, &scheduler.JobsRequest{Project: "bar"})
                         So(err, ShouldBeNil)
                         So(reply.GetJobs(), ShouldResemble, []*scheduler.Job{
                                 {
                                         JobRef:   &scheduler.JobRef{Job: "foo", Project: "bar"},
                                         Schedule: "0 * * * * * *",
                                         State:    &scheduler.JobState{UiStatus: "RUNNING"},
                                         Paused:   false,
                                 },
                         })
                 })
 
                 Convey("Paused but currently running job", func() {
-                        fakeEng.getProjectJobs = func(projectID string) ([]*engine.Job, error) {
+                        fakeEng.getProjectJobsRA = func(projectID string) ([]*engine.Job, error) {
                                 So(projectID, ShouldEqual, "bar")
                                 return []*engine.Job{
                                         {
                                                 // Job which is paused but its latest invocation still running.
                                                 JobID:     "bar/foo",
                                                 ProjectID: "bar",
                                                 Schedule:  "0 * * * * * *",
                                                 State:     engine.JobState{State: engine.JobStateRunning},
                                                 Paused:    true,
                                                 Task:      fakeTaskBlob,
@@ skipping 18 matching lines @@
         t.Parallel()
 
         Convey("Scheduler GetInvocations API works", t, func() {
                 ctx := gaetesting.TestingContext()
                 fakeEng, catalog := newTestEngine()
                 _, err := registerUrlFetcher(catalog)
                 So(err, ShouldBeNil)
                 ss := SchedulerServer{fakeEng, catalog}
 
                 Convey("Job not found", func() {
-                        fakeEng.getJob = func(JobID string) (*engine.Job, error) { return nil, nil }
+                        fakeEng.getJobRA = func(JobID string) (*engine.Job, error) { return nil, nil }
                         _, err := ss.GetInvocations(ctx, &scheduler.InvocationsRequest{
                                 JobRef: &scheduler.JobRef{Project: "not", Job: "exists"},
                         })
                         s, ok := status.FromError(err)
                         So(ok, ShouldBeTrue)
                         So(s.Code(), ShouldEqual, codes.NotFound)
                 })
 
                 Convey("DS error", func() {
-                        fakeEng.getJob = func(JobID string) (*engine.Job, error) { return nil, fmt.Errorf("ds error") }
+                        fakeEng.getJobRA = func(JobID string) (*engine.Job, error) { return nil, fmt.Errorf("ds error") }
                         _, err := ss.GetInvocations(ctx, &scheduler.InvocationsRequest{
                                 JobRef: &scheduler.JobRef{Project: "proj", Job: "job"},
                         })
                         s, ok := status.FromError(err)
                         So(ok, ShouldBeTrue)
                         So(s.Code(), ShouldEqual, codes.Internal)
                 })
 
-                fakeEng.getJob = func(JobID string) (*engine.Job, error) {
+                fakeEng.getJobRA = func(JobID string) (*engine.Job, error) {
                         return &engine.Job{JobID: "proj/job", ProjectID: "proj"}, nil
                 }
 
                 Convey("Emtpy with huge pagesize", func() {
                         fakeEng.listInvocations = func(pageSize int, cursor string) ([]*engine.Invocation, string, error) {
                                 So(pageSize, ShouldEqual, 50)
                                 So(cursor, ShouldEqual, "")
                                 return nil, "", nil
                         }
                         r, err := ss.GetInvocations(ctx, &scheduler.InvocationsRequest{
@@ skipping 196 matching lines @@
                 UrlFetch: &messages.UrlFetchTask{Url: "http://example.com/path"},
         })
 }
 
 func newTestEngine() (*fakeEngine, catalog.Catalog) {
         cat := catalog.New("scheduler.cfg")
         return &fakeEngine{}, cat
 }
 
 type fakeEngine struct {
-        getAllJobs      func() ([]*engine.Job, error)
-        getProjectJobs  func(projectID string) ([]*engine.Job, error)
-        getJob          func(jobID string) (*engine.Job, error)
-        listInvocations func(pageSize int, cursor string) ([]*engine.Invocation, string, error)
+        getAllJobsRA     func() ([]*engine.Job, error)
+        getProjectJobsRA func(projectID string) ([]*engine.Job, error)
+        getJobRA         func(jobID string) (*engine.Job, error)
+        listInvocations  func(pageSize int, cursor string) ([]*engine.Invocation, string, error)
 
         pauseJob        func(jobID string, who identity.Identity) error
         resumeJob       func(jobID string, who identity.Identity) error
         abortJob        func(jobID string, who identity.Identity) error
         abortInvocation func(jobID string, invID int64, who identity.Identity) error
 }
 
 func (f *fakeEngine) GetAllProjects(c context.Context) ([]string, error) {
         panic("not implemented")
 }
 
-func (f *fakeEngine) GetAllJobs(c context.Context) ([]*engine.Job, error) {
-        return f.getAllJobs()
+func (f *fakeEngine) GetAllJobsRA(c context.Context) ([]*engine.Job, error) {
+        return f.getAllJobsRA()
 }
 
-func (f *fakeEngine) GetProjectJobs(c context.Context, projectID string) ([]*engine.Job, error) {
-        return f.getProjectJobs(projectID)
+func (f *fakeEngine) GetProjectJobsRA(c context.Context, projectID string) ([]*engine.Job, error) {
+        return f.getProjectJobsRA(projectID)
 }
 
-func (f *fakeEngine) GetJob(c context.Context, jobID string) (*engine.Job, error) {
-        return f.getJob(jobID)
+func (f *fakeEngine) GetJobRA(c context.Context, jobID string) (*engine.Job, error) {
+        return f.getJobRA(jobID)
 }
 
 func (f *fakeEngine) ListInvocations(c context.Context, jobID string, pageSize int, cursor string) ([]*engine.Invocation, string, error) {
         return f.listInvocations(pageSize, cursor)
 }
 
 func (f *fakeEngine) GetInvocation(c context.Context, jobID string, invID int64) (*engine.Invocation, error) {
         panic("not implemented")
 }
 
@@ skipping 33 matching lines @@
         return f.resumeJob(jobID, who)
 }
 
 func (f *fakeEngine) AbortInvocation(c context.Context, jobID string, invID int64, who identity.Identity) error {
         return f.abortInvocation(jobID, invID, who)
 }
 
 func (f *fakeEngine) AbortJob(c context.Context, jobID string, who identity.Identity) error {
         return f.abortJob(jobID, who)
 }