[scheduler]: ACLs phase 1 - per Job ACL specification and enforcement.

scheduler/appengine/apiservers/scheduler.go

 // Copyright 2016 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 28 matching lines @@
 // GetJobs fetches all jobs satisfying JobsRequest and visibility ACLs.
 func (s SchedulerServer) GetJobs(ctx context.Context, in *scheduler.JobsRequest) (*scheduler.JobsReply, error) {
         if in.GetCursor() != "" {
                 // Paging in GetJobs isn't implemented until we have enough jobs to care.
                 // Until then, not empty cursor implies no more jobs to return.
                 return &scheduler.JobsReply{Jobs: []*scheduler.Job{}, NextCursor: ""}, nil
         }
         var ejobs []*engine.Job
         var err error
         if in.GetProject() == "" {
-                ejobs, err = s.Engine.GetAllJobs(ctx)
+                ejobs, err = s.Engine.GetAllJobsRA(ctx)
         } else {
-                ejobs, err = s.Engine.GetProjectJobs(ctx, in.GetProject())
+                ejobs, err = s.Engine.GetProjectJobsRA(ctx, in.GetProject())
         }
         if err != nil {
                 return nil, grpc.Errorf(codes.Internal, "datastore error: %s", err)
         }
 
         jobs := make([]*scheduler.Job, len(ejobs))
         for i, ej := range ejobs {
                 traits, err := presentation.GetJobTraits(ctx, s.Catalog, ej)
                 if err != nil {
                         return nil, grpc.Errorf(codes.Internal, "failed to get traits: %s", err)
                 }
                 jobs[i] = &scheduler.Job{
                         JobRef: &scheduler.JobRef{
                                 Project: ej.ProjectID,
                                 Job:     ej.GetJobName(),
                         },
                         Schedule: ej.Schedule,
                         State: &scheduler.JobState{
                                 UiStatus: string(presentation.GetPublicStateKind(ej, traits)),
                         },
                         Paused: ej.Paused,
                 }
         }
         return &scheduler.JobsReply{Jobs: jobs, NextCursor: ""}, nil
 }
 
 func (s SchedulerServer) GetInvocations(ctx context.Context, in *scheduler.InvocationsRequest) (*scheduler.InvocationsReply, error) {
-        ejob, err := s.Engine.GetJob(ctx, getJobId(in.GetJobRef()))
+        ejob, err := s.Engine.GetJobRA(ctx, getJobId(in.GetJobRef()))
         if err != nil {
                 return nil, grpc.Errorf(codes.Internal, "datastore error: %s", err)
         }
         if ejob == nil {
                 return nil, grpc.Errorf(codes.NotFound, "Job does not exist or you have no access")
         }
 
         pageSize := 50
         if in.PageSize > 0 && int(in.PageSize) < pageSize {
                 pageSize = int(in.PageSize)
@@ skipping 68 matching lines @@
         case err == engine.ErrNoSuchInvocation:
                 return nil, grpc.Errorf(codes.NotFound, "no such invocation")
         default:
                 return nil, grpc.Errorf(codes.Internal, "internal error: %s", err)
         }
 }
 
 func getJobId(jobRef *scheduler.JobRef) string {
         return jobRef.GetProject() + "/" + jobRef.GetJob()
 }