Issue 2986: TryFlatten is inlined, while Flatten is not. Make an optimization to avoid t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2986: TryFlatten is inlined, while Flatten is not. Make an optimization to avoid t... (Closed)

Created:
12 years, 3 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

TryFlatten is inlined, while Flatten is not. Make an optimization to avoid the call to Flatten when we're already flat. This gives me 5% on some simple indexOf experiments.

Patch Set 1 #

Patch Set 2 : Comments and check for external strings. #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/objects-inl.h	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

I'm not sure, this is a toss up. We can see what the bots say...

12 years, 3 months ago (2008-09-19 10:28:17 UTC) #1

Mads Ager (chromium)

12 years, 3 months ago (2008-09-19 10:34:08 UTC) #2

LGTM.

I would like to see some real life data on the percentage of calls that hit the
fast case.  My guess would be that it is hit a lot in practice, but I guess we
could easily gather such data using the test shell on a number of webapps.

Expand Messages | Collapse Messages