Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 2986: TryFlatten is inlined, while Flatten is not. Make an optimization to avoid t... (Closed)

Created:
12 years, 3 months ago by Dean McNamee
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

TryFlatten is inlined, while Flatten is not. Make an optimization to avoid the call to Flatten when we're already flat. This gives me 5% on some simple indexOf experiments.

Patch Set 1 #

Patch Set 2 : Comments and check for external strings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/objects-inl.h View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Dean McNamee
I'm not sure, this is a toss up. We can see what the bots say...
12 years, 3 months ago (2008-09-19 10:28:17 UTC) #1
Mads Ager (chromium)
12 years, 3 months ago (2008-09-19 10:34:08 UTC) #2
LGTM.

I would like to see some real life data on the percentage of calls that hit the
fast case.  My guess would be that it is hit a lot in practice, but I guess we
could easily gather such data using the test shell on a number of webapps.

Powered by Google App Engine
This is Rietveld 408576698