Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2985963002: [standalone] Register a segfault handler on Android as already done on Linux. (Closed)

Created:
3 years, 4 months ago by rmacnak
Modified:
3 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[standalone] Register a segfault handler on Android as already done on Linux. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/a86bc67d9ba2fffa5f79942edda4b1e111b7b37f

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M runtime/bin/platform_android.cc View 1 2 chunks +29 lines, -0 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/profiler.cc View 1 2 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmacnak
3 years, 4 months ago (2017-07-26 23:10:01 UTC) #3
siva
lgtm https://codereview.chromium.org/2985963002/diff/20001/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/2985963002/diff/20001/runtime/vm/profiler.cc#newcode1095 runtime/vm/profiler.cc:1095: OS::PrintErr("Stack dump aborted because CheckIsolate.\n"); "...... CheckIsolate failed.\n"
3 years, 4 months ago (2017-07-27 01:09:52 UTC) #4
rmacnak
https://codereview.chromium.org/2985963002/diff/20001/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/2985963002/diff/20001/runtime/vm/profiler.cc#newcode1095 runtime/vm/profiler.cc:1095: OS::PrintErr("Stack dump aborted because CheckIsolate.\n"); On 2017/07/27 01:09:52, siva ...
3 years, 4 months ago (2017-07-27 01:23:28 UTC) #5
rmacnak
3 years, 4 months ago (2017-07-27 16:47:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a86bc67d9ba2fffa5f79942edda4b1e111b7b37f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698