Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2985823002: Migrated test block 24 to Dart 2.0. (Closed)

Created:
3 years, 5 months ago by bkonyi
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 24 to Dart 2.0. Another fairly simple block. regress-standalone required the introduction of two seperate result variables as result was having two different types assigned to it at different times. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/64785f061496c50f49abc0611054ff79006da7e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2010 lines) Patch
M tests/corelib/corelib.status View 2 chunks +0 lines, -4 lines 0 comments Download
D tests/corelib/regexp/regress-regexp-codeflush_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/corelib/regexp/regress-regexp-construct-result_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/corelib/regexp/repeat-match-waldemar_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/corelib/regexp/results-cache_test.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D tests/corelib/regexp/stack-overflow2_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/corelib/regexp/stack-overflow_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D tests/corelib/regexp/standalones_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/corelib/regexp/toString_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D tests/corelib/regexp/unicode-handling_test.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D tests/corelib/regexp/unicodeCaseInsensitive_test.dart View 1 chunk +0 lines, -108 lines 0 comments Download
D tests/corelib/regexp/v8_regexp_utils.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D tests/corelib/regexp/zero-length-alternatives_test.dart View 1 chunk +0 lines, -279 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 3 chunks +14 lines, -0 lines 0 comments Download
A + tests/corelib_2/regexp/regress-regexp-codeflush_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/corelib_2/regexp/regress-regexp-construct-result_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/repeat-match-waldemar_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/results-cache_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/stack-overflow2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/stack-overflow_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/standalones_test.dart View 1 chunk +26 lines, -26 lines 0 comments Download
A + tests/corelib_2/regexp/toString_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/unicode-handling_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/unicodeCaseInsensitive_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/v8_regexp_utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/zero-length-alternatives_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -9 lines 0 comments Download
D tests/corelib_strong/regexp/regress-regexp-codeflush_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/corelib_strong/regexp/regress-regexp-construct-result_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/corelib_strong/regexp/repeat-match-waldemar_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/corelib_strong/regexp/results-cache_test.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D tests/corelib_strong/regexp/stack-overflow2_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/corelib_strong/regexp/stack-overflow_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D tests/corelib_strong/regexp/standalones_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/corelib_strong/regexp/toString_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D tests/corelib_strong/regexp/unicode-handling_test.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D tests/corelib_strong/regexp/unicodeCaseInsensitive_test.dart View 1 chunk +0 lines, -108 lines 0 comments Download
D tests/corelib_strong/regexp/v8_regexp_utils.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D tests/corelib_strong/regexp/zero-length-alternatives_test.dart View 1 chunk +0 lines, -279 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 5 months ago (2017-07-24 23:12:57 UTC) #2
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-25 21:39:10 UTC) #3
bkonyi
3 years, 5 months ago (2017-07-25 22:22:40 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
64785f061496c50f49abc0611054ff79006da7e9.

Powered by Google App Engine
This is Rietveld 408576698