Parse type variables of local functions before return type.

Parse type variables of local functions before return type.

R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/98422979ace090299f18bf8f7091aaa7cdf99071

[ahe, 2017-07-21 16:02:18]

ahe@google.com changed reviewers:
+ danrubel@google.com, johnniwinther@google.com

[ahe, 2017-07-21 16:02:19]

This is the last parser rewrite I need before implementing type variables on
local functions.

https://codereview.chromium.org/2985673002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (left):

https://codereview.chromium.org/2985673002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:1185:
listener.replaceTokenWithGenericCommentTypeAssign(begin, token);
This has already been called when we analyze the tokens above.

[danrubel, 2017-07-21 17:11:20]

LGTM with comment for you to address as you see fit.

https://codereview.chromium.org/2985673002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2985673002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:1270:
listener.beginFunctionName(token);
From this line down to the return statement looks the same as the code in the
above 3 change chunks. Can this code be moved into
parseLocalFunctionDeclarationFromFormals to reduce code duplication?

[ahe, 2017-08-07 11:45:27]

Thank you, Dan!

https://codereview.chromium.org/2985673002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2985673002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:1270:
listener.beginFunctionName(token);
On 2017/07/21 17:11:20, danrubel wrote:
> From this line down to the return statement looks the same as the code in the
> above 3 change chunks. Can this code be moved into
> parseLocalFunctionDeclarationFromFormals to reduce code duplication?

You inspired me to go a bit further, and I decided to move those changes to
their own CL (2999523002).

[ahe, 2017-08-07 11:46:54]

Description was changed from

==========
Parse type variables of local functions before return type.
==========

to

==========
Parse type variables of local functions before return type.

R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/98422979ace090299f18bf8f7091aaa7cdf99071
==========

[ahe, 2017-08-07 11:46:57]

Committed patchset #1 (id:1) manually as
98422979ace090299f18bf8f7091aaa7cdf99071 (presubmit successful).