Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2985663002: Remove _nodeToEntity and _nodeToThisLocal from CapturedScopeBuilder (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove _nodeToEntity and _nodeToThisLocal from CapturedScopeBuilder R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/049019bc0360f9930a81d217b6156c013740d3e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -60 lines) Patch
M pkg/compiler/lib/src/elements/entities.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_model/closure_visitors.dart View 6 chunks +23 lines, -59 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-21 15:08:07 UTC) #2
Emily Fortuna
lgtm
3 years, 5 months ago (2017-07-21 22:02:28 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-07-28 11:48:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
049019bc0360f9930a81d217b6156c013740d3e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698