Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: client/cmd/isolate/exp_archive.go

Issue 2985643002: Plumb through blacklist flag in exparchive. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/cmd/isolate/exp_archive.go
diff --git a/client/cmd/isolate/exp_archive.go b/client/cmd/isolate/exp_archive.go
index ea9d1276f7a875fc56aaf66706ec800f1b28e95e..b5cf5ccdbe527c6029a52eb37d3c44dd79840e5a 100644
--- a/client/cmd/isolate/exp_archive.go
+++ b/client/cmd/isolate/exp_archive.go
@@ -153,9 +153,8 @@ func (pw *partitioningWalker) walkFn(path string, info os.FileInfo, err error) e
}
// partitionDeps walks each of the deps, partioning the results into symlinks and files categorized by size.
-func partitionDeps(deps []string, rootDir string) (partitionedDeps, error) {
- // TODO(mcgreevy): initialize FilesystemView with blacklist.
- fsView, err := common.NewFilesystemView(rootDir, nil)
+func partitionDeps(deps []string, rootDir string, blacklist []string) (partitionedDeps, error) {
+ fsView, err := common.NewFilesystemView(rootDir, blacklist)
if err != nil {
return partitionedDeps{}, err
}
@@ -202,7 +201,7 @@ func (c *expArchiveRun) main() error {
checker := NewChecker(ctx, client)
uploader := NewUploader(ctx, client, 1)
- parts, err := partitionDeps(deps, rootDir)
+ parts, err := partitionDeps(deps, rootDir, c.isolateFlags.ArchiveOptions.Blacklist)
if err != nil {
return fmt.Errorf("partitioning deps: %v", err)
}
@@ -379,10 +378,6 @@ func (c *expArchiveRun) Run(a subcommands.Application, args []string, _ subcomma
fmt.Fprintf(a.GetErr(), "%s: %s\n", a.GetName(), err)
return 1
}
- if len(c.isolateFlags.ArchiveOptions.Blacklist) != 0 {
- fmt.Fprintf(a.GetErr(), "%s: blacklist is not supported\n", a.GetName())
- return 1
- }
if err := c.main(); err != nil {
fmt.Fprintf(a.GetErr(), "%s: %s\n", a.GetName(), err)
return 1
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698