Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 298563003: Move geometry types to a more central location. (Closed)

Created:
6 years, 7 months ago by Ben Goodger (Google)
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Move geometry types to a more central location. R=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271936

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : / #

Patch Set 4 : . #

Patch Set 5 : int32 for points/sizes. #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -86 lines) Patch
M mojo/aura/window_tree_host_mojo.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + mojo/geometry/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
A mojo/geometry/geometry_type_converters.h View 1 1 chunk +43 lines, -0 lines 0 comments Download
A mojo/geometry/geometry_type_converters.cc View 1 1 chunk +52 lines, -0 lines 0 comments Download
A mojo/geometry/mojo_geometry_export.h View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 5 6 2 chunks +18 lines, -0 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 5 chunks +8 lines, -0 lines 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +17 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 4 5 6 4 chunks +5 lines, -1 line 0 comments Download
A + mojo/public/interfaces/geometry/geometry.mojom View 1 2 3 4 1 chunk +13 lines, -2 lines 0 comments Download
M mojo/services/native_viewport/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
D mojo/services/native_viewport/geometry_conversions.h View 1 chunk +0 lines, -64 lines 0 comments Download
M mojo/services/native_viewport/native_viewport.mojom View 1 chunk +2 lines, -15 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Ben Goodger (Google)
6 years, 7 months ago (2014-05-20 20:00:48 UTC) #1
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 7 months ago (2014-05-20 20:26:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/298563003/60001
6 years, 7 months ago (2014-05-20 20:26:54 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 20:26:55 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-20 20:26:56 UTC) #5
sky
LGTM
6 years, 7 months ago (2014-05-20 22:50:15 UTC) #6
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 7 months ago (2014-05-20 23:43:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/298563003/100001
6 years, 7 months ago (2014-05-20 23:47:07 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 04:43:40 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 06:02:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/12221)
6 years, 7 months ago (2014-05-21 06:02:56 UTC) #11
Ben Goodger (Google)
6 years, 7 months ago (2014-05-21 19:08:37 UTC) #12
Message was sent while issue was closed. 
Committed patchset #7 manually as r271936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698