Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 2985593002: Fix co19_test script: --fast-startup is only an option for dart2js (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom, Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix co19_test script: --fast-startup is only an option for dart2js BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/64541f6bdcf92be725b0b14e8dea7e68162874b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/testing/dart/co19_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
minor: just something I noticed while doing other changes around here.
3 years, 5 months ago (2017-07-20 18:32:15 UTC) #2
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-20 19:38:56 UTC) #3
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-21 18:44:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
64541f6bdcf92be725b0b14e8dea7e68162874b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698