Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2985563003: Account for kernel files being passed in directly on the command line this fixes issue 30212 (https… (Closed)

Created:
3 years, 5 months ago by siva
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Account for kernel files being passed in directly on the command line this fixes issue 30212 (https://github.com/dart-lang/sdk/issues/30212) R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/000bec45acb7260b82ccc570a5652012a6c4b2a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -19 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/main.cc View 6 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
siva
3 years, 5 months ago (2017-07-21 00:53:31 UTC) #3
Siggi Cherem (dart-lang)
lgtm, thanks Siva
3 years, 5 months ago (2017-07-21 01:13:42 UTC) #4
siva
Committed patchset #1 (id:1) manually as 000bec45acb7260b82ccc570a5652012a6c4b2a4 (presubmit successful).
3 years, 5 months ago (2017-07-21 15:27:44 UTC) #6
zra
lgtm The logic in main.cc is difficult to follow, so we should probably consider factoring ...
3 years, 5 months ago (2017-07-21 16:06:12 UTC) #7
siva
3 years, 5 months ago (2017-07-21 16:45:56 UTC) #8
Message was sent while issue was closed.
On 2017/07/21 16:06:12, zra wrote:
> lgtm
> 
> The logic in main.cc is difficult to follow, so we should probably consider
> factoring the different ways of loading programs and creating isolates into
> separate source files.

Agree, some refactoring between application snapshots and source/kernel is a
good idea. Will do that.

Powered by Google App Engine
This is Rietveld 408576698