chrome/browser/resources/options/search_page.js - Issue 298553002: Options: maintain history entries on the parent frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_page.js

Issue 298553002: Options: maintain history entries on the parent frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: dbeam comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/search_page.js

diff --git a/chrome/browser/resources/options/search_page.js b/chrome/browser/resources/options/search_page.js

index 0debf8e7cfa23702a4a3f1a3adb29e1b7f1f2b10..cd72ba5f38354c0c002bc115e83bf026c8fdecbc 100644

--- a/chrome/browser/resources/options/search_page.js

+++ b/chrome/browser/resources/options/search_page.js

@@ -272,8 +272,7 @@ cr.define('options', function() {

// Set the hash on the current page, and the enclosing uber page

var hash = text ? '#' + encodeURIComponent(text) : '';

var path = text ? this.name : '';

- window.location.hash = hash;

- uber.invokeMethodOnParent('setPath', {path: path + hash});

+ uber.pushState({}, path + hash);

// Toggle the search page if necessary.

if (text) {