Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: build/config/android/internal_rules.gni

Issue 2985523002: Update experimental Java 8 support to use Desugar instead of Retrolambda (Closed)
Patch Set: addressing comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/gyp/retrolambda.py ('K') | « build/android/gyp/retrolambda.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index d7712d5363c1debd13b3113992a120d4cad1e88f..83b9986f191b7ab304a365d7005d287270a9c22e 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -1181,10 +1181,10 @@ if (enable_java_templates) {
defined(invoker.supports_android) && invoker.supports_android &&
(is_java_debug || dcheck_always_on)
- _retrolambda =
+ _desugar =
defined(invoker.supports_android) && invoker.supports_android &&
((defined(invoker.process_java8) && invoker.process_java8) || use_java8)
-
+
_deps = []
_previous_output_jar = _input_jar_path
@@ -1260,14 +1260,13 @@ if (enable_java_templates) {
_previous_output_jar = _assert_output_jar
}
- if (_retrolambda) {
- _retrolambda_target = "${target_name}__retrolambda"
- _retrolambda_input_jar = _previous_output_jar
- _retrolambda_output_jar = "$target_out_dir/$target_name-retrolambda.jar"
+ if (_desugar) {
+ _desugar_target = "${target_name}__desugar"
+ _desugar_input_jar = _previous_output_jar
+ _desugar_output_jar = "$target_out_dir/$target_name-desugar.jar"
- android_sdk_jar = "$android_sdk/android.jar"
- action(_retrolambda_target) {
- script = "//build/android/gyp/retrolambda.py"
+ action(_desugar_target) {
+ script = "//build/android/gyp/desugar.py"
deps = _deps
if (defined(invoker.deps)) {
deps += invoker.deps
@@ -1277,27 +1276,35 @@ if (enable_java_templates) {
}
inputs = [
_build_config,
- _retrolambda_input_jar,
+ _desugar_input_jar,
]
outputs = [
- _retrolambda_output_jar,
+ _desugar_output_jar,
]
+ if (defined(invoker.alternative_android_sdk_ijar)) {
+ deps += [ invoker.alternative_android_sdk_ijar_dep ]
+ _android_sdk_ijar = invoker.alternative_android_sdk_ijar
+ } else {
+ deps += [ "//build/android:android_ijar" ]
+ _android_sdk_ijar = "$root_out_dir/lib.java/android.interface.jar"
+ }
+ inputs += [ _android_sdk_ijar ]
args = [
"--input-jar",
- rebase_path(_retrolambda_input_jar, root_build_dir),
+ rebase_path(_desugar_input_jar, root_build_dir),
"--output-jar",
- rebase_path(_retrolambda_output_jar, root_build_dir),
+ rebase_path(_desugar_output_jar, root_build_dir),
"--classpath=@FileArg($_rebased_build_config:javac:classpath)",
- "--android-sdk-jar",
- rebase_path(android_sdk_jar, root_build_dir),
+ "--bootclasspath-entry",
+ rebase_path(_android_sdk_ijar, root_build_dir),
]
}
_deps = []
- _deps = [ ":$_retrolambda_target" ]
- _previous_output_jar = _retrolambda_output_jar
+ _deps = [ ":$_desugar_target" ]
+ _previous_output_jar = _desugar_output_jar
}
-
+
_output_jar_target = "${target_name}__copy"
copy(_output_jar_target) {
deps = _deps
@@ -2048,8 +2055,8 @@ if (enable_java_templates) {
forward_variables_from(invoker,
[
"jar_excluded_patterns",
- "strip_resource_classes",
"process_java8",
+ "strip_resource_classes",
])
visibility = [
@@ -2341,7 +2348,12 @@ if (enable_java_templates) {
}
process_java_prebuilt(_process_prebuilt_target_name) {
- forward_variables_from(invoker, [ "jar_excluded_patterns" ])
+ forward_variables_from(invoker,
+ [
+ "alternative_android_sdk_ijar",
+ "alternative_android_sdk_ijar_dep",
+ "jar_excluded_patterns",
+ ])
supports_android = _supports_android
build_config = _build_config
input_jar_path = _javac_jar_path
« build/android/gyp/retrolambda.py ('K') | « build/android/gyp/retrolambda.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698