Issue 2985503002: Parenthesize expressions as needed in elements text dump.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2985503002: Parenthesize expressions as needed in elements text dump. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Parenthesize expressions as needed in elements text dump. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f04aa833c14c384e2a94aae0c282ce4ad688a920

Patch Set 1 #

Total comments: 1

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -5 lines)			Patch
M	pkg/analyzer/test/src/summary/element_text.dart	View	4 chunks	+17 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_common.dart	View	1 chunk	+14 lines, -0 lines	1 comment	Download
M	pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as f04aa833c14c384e2a94aae0c282ce4ad688a920 (presubmit successful).

3 years, 5 months ago (2017-07-19 19:29:45 UTC) #4

Brian Wilkerson

3 years, 5 months ago (2017-07-19 19:33:15 UTC) #5

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/2985503002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_common.dart (right):

https://codereview.chromium.org/2985503002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_common.dart:4648:
test_const_topLevel_parenthesis() async {
Should this also test that unnecessary parentheses are dropped?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages