Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2985473002: Update the checked-in d8 shell for Windows and Linux to version 6.1.0 (candidate) (Closed)

Created:
3 years, 5 months ago by Bill Hesse
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update the checked-in d8 shell for Windows and Linux to version 6.1.0 (candidate) BUG=https://github.com/dart-lang/sdk/issues/29794 The Linux ARM version of d8 is removed, because the architecture-dependent snapshot files are incompatible with the current directory structure. The Mac version is not yet updated because we need to do a custom build of it. The bug above is tracking this work. R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/2842ba70b62047bfde090e406ceb225116fa19b0

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove stray blank line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M third_party/d8/README.google View 1 1 chunk +10 lines, -6 lines 0 comments Download
M third_party/d8/linux/d8.sha1 View 1 chunk +1 line, -1 line 0 comments Download
D third_party/d8/linux/d8-arm.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/d8/linux/natives_blob.bin.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/snapshot_blob.bin.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/d8/windows/d8.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download
A third_party/d8/windows/natives_blob.bin.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/windows/snapshot_blob.bin.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
https://codereview.chromium.org/2985473002/diff/1/third_party/d8/README.google File third_party/d8/README.google (right): https://codereview.chromium.org/2985473002/diff/1/third_party/d8/README.google#newcode19 third_party/d8/README.google:19: Will fix the stray line.
3 years, 5 months ago (2017-07-19 16:48:34 UTC) #2
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-19 17:29:11 UTC) #3
Bill Hesse
3 years, 5 months ago (2017-07-20 00:12:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2842ba70b62047bfde090e406ceb225116fa19b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698