Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2985373002: Revert of [Password Manager] Send username correction votes (Closed)

Created:
3 years, 4 months ago by adithyas
Modified:
3 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, browser-components-watch_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, jam, mathp+autofillwatch_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, rogerm+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, vabr+watchlistpasswordmanager_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Password Manager] Send username correction votes (patchset #20 id:440001 of https://codereview.chromium.org/2747733004/ ) Reason for revert: Suspect that this is causing browser_tests and interactive_ui_tests failures Original issue's description: > [Password Manager] Send username correction votes > > If a user changes autofilled username on a form, but the correct username is in |PasswordForm.other_possible_usernames|, send USERNAME vote for the element that contained the correct username. > > This CL changes the data structure of |other_possible_usernames| from vector<string> to vector<pair<string, string>>. > > The CL updates only one local storage - login_database. We need to receive enough votes, there is no need to cover 100% of Chrome instances. But the results based on the votes would propagated to all instances. > > BUG=699530 > > Review-Url: https://codereview.chromium.org/2747733004 > Cr-Commit-Position: refs/heads/master@{#458788} > Committed: https://chromium.googlesource.com/chromium/src/+/718d242b21b1964f8a06e79bf00dcce7e073dac7 TBR=mkwst@chromium.org,dvadym@chromium.org,vabr@chromium.org,kolos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=699530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -525 lines) Patch
M components/autofill/content/common/autofill_types.mojom View 2 chunks +1 line, -7 lines 0 comments Download
M components/autofill/content/common/autofill_types.typemap View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/common/autofill_types_struct_traits.h View 2 chunks +2 lines, -17 lines 0 comments Download
M components/autofill/content/common/autofill_types_struct_traits.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M components/autofill/content/common/autofill_types_struct_traits_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.cc View 7 chunks +15 lines, -26 lines 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc View 6 chunks +20 lines, -46 lines 0 comments Download
M components/autofill/core/common/password_form.h View 3 chunks +1 line, -11 lines 0 comments Download
M components/autofill/core/common/password_form.cc View 3 chunks +3 lines, -14 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/login_database.cc View 8 chunks +45 lines, -62 lines 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 4 chunks +12 lines, -19 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 4 chunks +3 lines, -25 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 14 chunks +49 lines, -105 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 11 chunks +25 lines, -68 lines 0 comments Download
D components/test/data/password_manager/login_db_v19.sql View 1 chunk +0 lines, -110 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adithyas
Created Revert of [Password Manager] Send username correction votes
3 years, 4 months ago (2017-07-31 21:15:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2985373002/1
3 years, 4 months ago (2017-07-31 21:16:04 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/190531) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 4 months ago (2017-07-31 21:20:39 UTC) #5
kolos1
Hi Adithya! In revert reason, please give more info about test failures. Interactive test is ...
3 years, 4 months ago (2017-08-01 08:58:23 UTC) #6
adithyas
3 years, 4 months ago (2017-08-01 12:50:25 UTC) #7
Message was sent while issue was closed.
On 2017/08/01 at 08:58:23, kolos wrote:
> Hi Adithya!
> 
> In revert reason, please give more info about test failures. Interactive test
is very flaky, so please double check that you revert the right CL.
> 
> This CL doesn't change any UI behavior. It hardly affect on interactive tests.
> 
> All the best,
> Maxim

Hey! Sorry about that, I realized this CL couldn't have caused the failures so I
just closed the issue after the try bots failed.

Powered by Google App Engine
This is Rietveld 408576698