Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart

Issue 2985253002: [corelib] dart:developer timeline flow events (Closed)
Patch Set: Update changelog Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/timeline.dart ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart
diff --git a/runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart b/runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart
index 0024f1022980a5a779a60485e1b028b551ac63fe..fdbc61fc3134b208ecef13c33cbfb730b8ecac17 100644
--- a/runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart
+++ b/runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart
@@ -17,6 +17,14 @@ primeTimeline() {
task.start('TASK1');
task.instant('ITASK');
task.finish();
+
+ Flow flow = Flow.begin();
+ Timeline.startSync('peach', flow: flow);
+ Timeline.finishSync();
+ Timeline.startSync('watermelon', flow: Flow.step(flow.id));
+ Timeline.finishSync();
+ Timeline.startSync('pear', flow: Flow.end(flow.id));
+ Timeline.finishSync();
}
List<Map> filterForDartEvents(List<Map> events) {
@@ -92,7 +100,7 @@ var tests = [
expect(result['traceEvents'], new isInstanceOf<List>());
final int numEvents = result['traceEvents'].length;
List<Map> dartEvents = filterForDartEvents(result['traceEvents']);
- expect(dartEvents.length, equals(5));
+ expect(dartEvents.length, equals(11));
allEventsHaveIsolateNumber(dartEvents);
allEventsHaveIsolateNumber(result['traceEvents']);
expect(eventsContains(dartEvents, 'I', 'ISYNC'), isTrue);
@@ -101,6 +109,9 @@ var tests = [
expect(eventsContains(dartEvents, 'e', 'TASK1'), isTrue);
expect(eventsContains(dartEvents, 'n', 'ITASK'), isTrue);
expect(eventsContains(dartEvents, 'q', 'ITASK'), isFalse);
+ expect(eventsContains(dartEvents, 's', 'peach'), isTrue);
+ expect(eventsContains(dartEvents, 't', 'watermelon'), isTrue);
+ expect(eventsContains(dartEvents, 'f', 'pear'), isTrue);
// Calculate the time Window of Dart events.
int origin = timeOrigin(dartEvents);
int extent = timeDuration(dartEvents, origin);
« no previous file with comments | « runtime/lib/timeline.dart ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698