Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2985243002: Migrate block 44. (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
Reviewers:
bkonyi
CC:
dart2now-team_google.com, reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1767 lines) Patch
M pkg/expect/lib/expect.dart View 1 chunk +4 lines, -0 lines 0 comments Download
D tests/language/bool_check_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D tests/language/bool_condition_check_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D tests/language/bool_test.dart View 1 chunk +0 lines, -210 lines 0 comments Download
D tests/language/bootstrap_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language/bound_closure_equality_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D tests/language/bound_closure_primitives_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/language/branch_canonicalization_test.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D tests/language/branches_test.dart View 1 chunk +0 lines, -159 lines 0 comments Download
D tests/language/break_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/language/built_in_identifier_illegal_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_abstract.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_as.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_dynamic.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_export.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_external.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_factory.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_get.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_implements.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_import.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_library.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_operator.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_part.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_set.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_static.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/built_in_identifier_prefix_library_typedef.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M tests/language/language_dart2js.status View 5 chunks +0 lines, -13 lines 0 comments Download
A tests/language_2/bool_check_test.dart View 1 chunk +15 lines, -0 lines 1 comment Download
A + tests/language_2/bool_condition_check_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download
A + tests/language_2/bool_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bootstrap_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bound_closure_equality_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
A + tests/language_2/bound_closure_primitives_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language_2/branch_canonicalization_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/branches_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/break_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_illegal_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_abstract.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_as.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_dynamic.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_export.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_external.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_factory.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_get.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_implements.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_import.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_library.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_operator.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_part.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_set.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_static.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_library_typedef.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language_2/language_2.status View 7 chunks +22 lines, -0 lines 0 comments Download
D tests/language_strong/bool_check_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D tests/language_strong/bool_condition_check_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D tests/language_strong/bool_test.dart View 1 chunk +0 lines, -210 lines 0 comments Download
D tests/language_strong/bootstrap_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language_strong/bound_closure_equality_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D tests/language_strong/bound_closure_primitives_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/language_strong/branch_canonicalization_test.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D tests/language_strong/branches_test.dart View 1 chunk +0 lines, -159 lines 0 comments Download
D tests/language_strong/break_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/language_strong/built_in_identifier_illegal_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_abstract.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_as.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_dynamic.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_export.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_external.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_factory.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_get.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_implements.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_import.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_library.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_operator.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_part.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_set.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_static.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_library_typedef.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M tests/language_strong/language_strong.status View 2 chunks +0 lines, -6 lines 0 comments Download
M tests/language_strong/language_strong_kernel.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 4 months ago (2017-07-28 02:42:57 UTC) #2
bkonyi
LGTM after fixing copyright year. https://codereview.chromium.org/2985243002/diff/1/tests/language_2/bool_check_test.dart File tests/language_2/bool_check_test.dart (right): https://codereview.chromium.org/2985243002/diff/1/tests/language_2/bool_check_test.dart#newcode1 tests/language_2/bool_check_test.dart:1: // Copyright (c) 2014, ...
3 years, 4 months ago (2017-07-28 19:41:39 UTC) #3
Bob Nystrom
3 years, 4 months ago (2017-08-02 20:45:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9d4be009868c285cc69194c71def3471bc5037f5.

Powered by Google App Engine
This is Rietveld 408576698