Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2985233002: Migrated test block 19 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Migrated test block 19 to Dart 2.0. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2531 lines) Patch
M tests/corelib/corelib.status View 1 4 chunks +0 lines, -31 lines 0 comments Download
D tests/corelib/range_error_test.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tests/corelib/reg_exp1_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib/reg_exp4_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/corelib/reg_exp5_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/corelib/reg_exp_all_matches_test.dart View 1 chunk +0 lines, -118 lines 0 comments Download
D tests/corelib/reg_exp_first_match_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/corelib/reg_exp_group_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/corelib/reg_exp_groups_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/corelib/reg_exp_has_match_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/corelib/reg_exp_pattern_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib/reg_exp_start_end_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/corelib/reg_exp_string_match_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/corelib/regexp/UC16_test.dart View 1 chunk +0 lines, -71 lines 0 comments Download
D tests/corelib/regexp/alternative-length-miscalculation_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/corelib/regexp/alternatives_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D tests/corelib/regexp/ascii-regexp-subject_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/corelib/regexp/assertion_test.dart View 1 chunk +0 lines, -117 lines 0 comments Download
D tests/corelib/regexp/backreferences_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/corelib/regexp/bol-with-multiline_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/corelib/regexp/bol_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/corelib/regexp/capture-3_test.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D tests/corelib/regexp/capture_test.dart View 1 chunk +0 lines, -57 lines 0 comments Download
D tests/corelib/regexp/captures_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/corelib/regexp/char-insensitive_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D tests/corelib/regexp/character-match-out-of-order_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 3 chunks +38 lines, -0 lines 0 comments Download
A + tests/corelib_2/range_error_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp5_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp_all_matches_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp_first_match_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp_group_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp_groups_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp_has_match_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp_pattern_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp_start_end_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/reg_exp_string_match_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/UC16_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/alternative-length-miscalculation_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/alternatives_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/ascii-regexp-subject_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/assertion_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/backreferences_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/bol-with-multiline_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/bol_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/capture-3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/capture_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/captures_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/char-insensitive_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/character-match-out-of-order_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 2 chunks +0 lines, -7 lines 0 comments Download
D tests/corelib_strong/range_error_test.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tests/corelib_strong/reg_exp1_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib_strong/reg_exp4_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/corelib_strong/reg_exp5_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/corelib_strong/reg_exp_all_matches_test.dart View 1 chunk +0 lines, -118 lines 0 comments Download
D tests/corelib_strong/reg_exp_first_match_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/corelib_strong/reg_exp_group_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/corelib_strong/reg_exp_groups_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/corelib_strong/reg_exp_has_match_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/corelib_strong/reg_exp_pattern_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib_strong/reg_exp_start_end_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/corelib_strong/reg_exp_string_match_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/corelib_strong/regexp/UC16_test.dart View 1 chunk +0 lines, -71 lines 0 comments Download
D tests/corelib_strong/regexp/alternative-length-miscalculation_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/corelib_strong/regexp/alternatives_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D tests/corelib_strong/regexp/ascii-regexp-subject_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/corelib_strong/regexp/assertion_test.dart View 1 chunk +0 lines, -117 lines 0 comments Download
D tests/corelib_strong/regexp/backreferences_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/corelib_strong/regexp/bol-with-multiline_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/corelib_strong/regexp/bol_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/corelib_strong/regexp/capture-3_test.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D tests/corelib_strong/regexp/capture_test.dart View 1 chunk +0 lines, -57 lines 0 comments Download
D tests/corelib_strong/regexp/captures_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/corelib_strong/regexp/char-insensitive_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D tests/corelib_strong/regexp/character-match-out-of-order_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 4 months ago (2017-07-27 21:25:39 UTC) #2
Bob Nystrom
lgtm
3 years, 4 months ago (2017-07-27 22:52:17 UTC) #3
bkonyi
3 years, 4 months ago (2017-07-31 16:49:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
011c9b0f759fdce052a9807458890033403f91a1.

Powered by Google App Engine
This is Rietveld 408576698