Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 298523002: [Android] Use the omnibox paste sanitizing code. (Closed)

Created:
6 years, 7 months ago by Ted C
Modified:
6 years, 7 months ago
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

[Android] Use the omnibox paste sanitizing code. BUG=374176 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271533

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove extra blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
A chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxViewUtil.java View 1 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/android/omnibox/omnibox_view_util.h View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/ui/android/omnibox/omnibox_view_util.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ted C
PTAL
6 years, 7 months ago (2014-05-19 21:14:11 UTC) #1
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/298523002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxViewUtil.java File chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxViewUtil.java (right): https://chromiumcodereview.appspot.com/298523002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxViewUtil.java#newcode23 chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxViewUtil.java:23: extra blank line?
6 years, 7 months ago (2014-05-19 21:21:00 UTC) #2
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 7 months ago (2014-05-19 21:28:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/298523002/20001
6 years, 7 months ago (2014-05-19 21:28:57 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 02:00:19 UTC) #5
Message was sent while issue was closed.
Change committed as 271533

Powered by Google App Engine
This is Rietveld 408576698