Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2580)

Unified Diff: appengine/config_service/ui/src/config-ui/config-set.html

Issue 2985223002: config_service: Changed file links to point to latest revision instead of master (Closed)
Patch Set: Fixed nit on test label Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/config_service/ui/test/config-ui/config-set_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/config_service/ui/src/config-ui/config-set.html
diff --git a/appengine/config_service/ui/src/config-ui/config-set.html b/appengine/config_service/ui/src/config-ui/config-set.html
index b68ec3581e2a9cde3fbd7dcc89ff10ccf9c9a5ab..f442d03437c8394bfa2e31a3158507d341092cd5 100644
--- a/appengine/config_service/ui/src/config-ui/config-set.html
+++ b/appengine/config_service/ui/src/config-ui/config-set.html
@@ -152,7 +152,7 @@
<template is="dom-repeat" items="[[files]]" as="file">
<div class="center config-card">
<config-file-card
- name="[[file.path]]" link="[[location]]/[[file.path]]">
+ name="[[file.path]]" link="[[url]]/[[file.path]]">
</config-file-card>
</div>
</template>
@@ -198,7 +198,7 @@
type: Object
},
- location: {
+ url: {
type: String
},
@@ -256,10 +256,14 @@
},
_onGotConfigFiles: function(event) {
- this.files = event.detail.response.config_sets[0].files || [];
- this.location = event.detail.response.config_sets[0].location;
- this.lastImportAttempt =
- event.detail.response.config_sets[0].last_import_attempt || null;
+ var config_set = event.detail.response.config_sets[0];
+ this.files = config_set.files || [];
+ this.lastImportAttempt = config_set.last_import_attempt || null;
+ if (config_set.revision && config_set.revision.url) {
+ this.url = config_set.revision.url;
+ } else {
+ this.url = config_set.location;
+ }
this.isLoading = false;
this.errorMessage = null;
this.fire('processedConfigFiles');
« no previous file with comments | « no previous file | appengine/config_service/ui/test/config-ui/config-set_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698