[vm] Add error messages for large literals coming from kernel

runtime/vm/kernel_binary_flowgraph.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/kernel_binary_flowgraph.h"
 
 #include "vm/compiler.h"
 #include "vm/longjump.h"
 #include "vm/object_store.h"
 
@@ skipping 2249 matching lines @@
         builder_->ReaderOffset(), false));  // read rest of initializer.
   }
 
   EvaluateExpression(builder_->ReaderOffset(), false);  // read body
 }
 
 void StreamingConstantEvaluator::EvaluateBigIntLiteral() {
   const dart::String& value =
       H.DartString(builder_->ReadStringReference());  // read string reference.
   result_ = Integer::New(value, Heap::kOld);
+  if (result_.IsNull()) {
+    H.ReportError("Integer literal %s is out of range", value.ToCString());

[zra, 2017/07/27 16:31:44]

If code after ReportError is unreachable, it can be helpful to put an
UNREACHABLE() after.

[alexmarkov, 2017/07/28 17:42:43]

Done.

+  }
   result_ = H.Canonicalize(result_);
 }
 
 void StreamingConstantEvaluator::EvaluateStringLiteral() {
   result_ = H.DartSymbol(builder_->ReadStringReference())
                 .raw();  // read string reference.
 }
 
 void StreamingConstantEvaluator::EvaluateIntLiteral(uint8_t payload) {
   int64_t value = static_cast<int32_t>(payload) - SpecializedIntLiteralBias;
@@ skipping 3487 matching lines @@
   instructions += BuildExpression();                   // read body.
   return instructions;
 }
 
 Fragment StreamingFlowGraphBuilder::BuildBigIntLiteral(
     TokenPosition* position) {
   if (position != NULL) *position = TokenPosition::kNoSource;
 
   const dart::String& value =
       H.DartString(ReadStringReference());  // read index into string table.
-  return Constant(Integer::ZoneHandle(Z, Integer::New(value, Heap::kOld)));
+  const Integer& integer =
+      Integer::ZoneHandle(Z, Integer::New(value, Heap::kOld));
+  if (integer.IsNull()) {
+    H.ReportError("Integer literal %s is out of range", value.ToCString());
+  }
+  return Constant(integer);
 }
 
 Fragment StreamingFlowGraphBuilder::BuildStringLiteral(
     TokenPosition* position) {
   if (position != NULL) *position = TokenPosition::kNoSource;
 
   return Constant(
       H.DartSymbol(ReadStringReference()));  // read index into string table.
 }
 
@@ skipping 1483 matching lines @@
     }
   }
 
   return Array::Handle(Array::null());
 }
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)